fix(pg): lock numpy to v1.24.4 until pandas supports 2.X.X #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut
Pandas doesn't fully support numpy 2+ . Our unit tests encounter a breaking change with the C API.
This can also be recreated by doing:
More info here: numpy/numpy#26710
Also: because CI uses python 3.8 to run tests we have to lock it at 1.24.4. If we were using python3.9+ on CI we could use 1.26.4 (last release of numpy 1).
Type of change
Acceptance
rm -r venv3/
)make test
inclouds/postgres
- it will error with a stacktrace as abovepg-pandas-geopandas-are-incompatible-with
make test
again and they will run + passNote: this bug also affects analytics-toolbox (premium). This fix in core will fix core and premium.
I'm not sure why CI hasn't failed yet. Maybe dependencies are cached.
Basic checklist