Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(sf): added warehouse option for SF #524

Merged

Conversation

volaya
Copy link
Contributor

@volaya volaya commented Sep 3, 2024

Description

Shortcut

Copy link
Contributor

@vdelacruzb vdelacruzb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would just add the optional parameter also in the docs in core/clouds/snowflake/README.md before merging.

@volaya volaya force-pushed the chore/sc-329793/add-optional-warehouse-env-variable-to-at branch from f608a26 to fa0cc09 Compare September 3, 2024 10:21
@volaya volaya merged commit 874ffae into main Sep 3, 2024
10 checks passed
@vdelacruzb vdelacruzb mentioned this pull request Sep 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants