Add labels to BQ uploaded tables #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #394522: Modify raster-loader to add labels to BQ uploads. |
Jesus89
reviewed
Mar 13, 2024
raster_loader/io/bigquery.py
Outdated
| @@ -161,6 +163,9 @@ def done_callback(job): | |||
| print("Writing metadata to BigQuery...") | |||
| self.write_metadata(metadata, append_records, fqn) | |||
|
|
|||
| print("Updating labels...") | |||
| self.update_labels(fqn, {"raster_loader": re.sub(r'[^a-z0-9_-]', '_', __version__.lower())}) | |||
There was a problem hiding this comment.
You can wrap this in a function and add a unit test for the function, to ensure any future changes do not break the integration with the raster tables in the platform.
Jesus89
approved these changes
Mar 13, 2024
thedae
deleted the
feature/sc-394522/modify-raster-loader-to-add-labels-to-bq
branch
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adding a
raster_loaderlabel to BQ tables containing the current package versionPull Request Checklist