Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CATROID-1611 Add CLT for GoToFront brick #5035

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Frajhamster
Copy link
Contributor

Added a CLT for a GoToFront brick.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@reichli reichli self-assigned this Sep 25, 2024
Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general approach of the test, how you are using the ability to interact with the sprite/ball as a means to verify that it's actually come to the front.

There are two things that should be added before we merge this:

  • Could you please additionally verify that the ball's current look is actually rendered at that click position? It is sufficient to check the color of a pixel at that position.
  • Please remove any unused resources from the project (sounds, etc.) that would otherwise unnecessarily bloat the file.

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants