Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce services.php by using attributes, and better structured config #5247

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

dmetzner
Copy link
Collaborator


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

TODO: Add additional information that is not in your commit-message here

@dmetzner dmetzner force-pushed the services branch 9 times, most recently from 1621e11 to 9a2f537 Compare September 15, 2024 16:27
Signed-off-by: Daniel Metzner <daniiel.metzner@gmail.com>
@dmetzner dmetzner marked this pull request as ready for review September 16, 2024 06:09
@dmetzner dmetzner merged commit df670ed into develop Sep 16, 2024
50 checks passed
@dmetzner dmetzner deleted the services branch October 4, 2024 12:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant