Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

STCC-134 Replace conversion error with warning #118

Merged
merged 1 commit into from
Mar 25, 2019
Merged

STCC-134 Replace conversion error with warning #118

merged 1 commit into from
Mar 25, 2019

Conversation

sandra0521
Copy link
Contributor

No description provided.

@AntiDog
Copy link
Contributor

AntiDog commented Mar 25, 2019

test_fail_convert_doplaysoundandwait_block (main.TestConvertBlocks)
and test_fail_convert_doplaysoundandwait_block (main.TestConvertBlocks)
fail currently. We need to fix this.

AntiDog
AntiDog suggested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@AntiDog AntiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_fail_convert_doplaysoundandwait_block (main.TestConvertBlocks)
and test_fail_convert_doplaysoundandwait_block (main.TestConvertBlocks)
fail currently. We need to fix this.

@AntiDog AntiDog force-pushed the STCC-134_missing_sound_error_to_warning branch from 347a915 to 0bb73d6 Compare March 25, 2019 14:44
@AntiDog AntiDog merged commit 59c22cf into Catrobat:develop Mar 25, 2019
@sandra0521 sandra0521 deleted the STCC-134_missing_sound_error_to_warning branch October 17, 2019 07:52
@sandra0521 sandra0521 mentioned this pull request Jul 2, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AntiDog AntiDog AntiDog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandra0521 @AntiDog