[STCC-155-224] rename media files #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandra0521
suggested changes
Apr 1, 2020
| def _generate_mouse_filename(): | ||
| mouse_path = _mouse_image_path() | ||
| return common.md5_hash(mouse_path) + "_" + MOUSE_SPRITE_FILENAME | ||
| def _get_mouse_filename(): |
There was a problem hiding this comment.
The call to this function in converter.py line 688 was not adapted to the new name so there is an error when converting a project with mouse cursor. This should be fixed.
sandra0521
reviewed
Apr 1, 2020
| for info in catrobat.media_objects_in(self.catrobat_program): | ||
| basename, _ = os.path.splitext(info.fileName) | ||
|
|
||
| # ignore these files, already correctly provided by the converter |
There was a problem hiding this comment.
Just a thought: key sprites are now the only ones left being saved with a hash in their name. If those are not necessary, it would be cleaner to remove those hashes too. This could maybe be done in _key_filename_for in converter.py.
oiduh
force-pushed
the
STCC-155-224_rename_files_and_create_copy_for_each_costume_and_sound
branch
from
5a49c53 to
92cb95e
Compare
oiduh
force-pushed
the
STCC-155-224_rename_files_and_create_copy_for_each_costume_and_sound
branch
from
92cb95e to
c8276c3
Compare
|
All requested changes were made. Regarding the second comment: i changed how the filenames for mouse cursor and keys are created initially, so they already have a name without hash. |
sandra0521
approved these changes
Apr 2, 2020
…_for_each_costume_and_sound
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially all costumes and sounds were named using the following information from the scratch project file:
Since the same images result in the same md5-hash and different objects can have a costume with the same name, it was possible that some files had the same name, which resulted in overwriting of existing files -> not all costumes and sounds had their own resource file. This was a problem for catrobat, because deleting e.g. a costume of an object could also have an impact on other objects (costume deleted as well).
The new proposed solution is to name the files as following:
These names are used until conversion of all unconverted files is finished, then the names of the catrobat files are replaced with something like "img_#0.png" and "snd_#0.wav" to keep it short and simple.
It was also considered to name the files after object and costume/sound name, which resulted in the following problems:
One last possible solution to name the files after object + costume/sound would be to cut the names to a certain length and add an id at the end, if collisions occur -> debatable how useful this naming convention is.