Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

STCC-140 handling of FormulaElement in sound bricks #167

Merged

Conversation

oiduh
Copy link
Contributor

@oiduh oiduh commented Apr 4, 2020

The ticket contains outdated information about the problems with the sound bricks. The code for this ticket includes some warnings, that tell the programmer what exactly went wrong during the conversion of these sound bricks. Currently there are 3 possible conversion warnings:

  1. The sound list in scratch is empty and no sound can be played
  2. The parameter for the brick is a formula or a variable, which is not yet handled in Pocket Code
  3. The sound from the drop down menu is not available anymore (possible if the sound is deleted, after it was selected in the drop down menu)

In the last 2 cases, if the sound list is not empty, the first sound in the list will be selected instead.

A new ticket with detailed information for the sound bricks will be created.

Copy link
Contributor

@11possim 11possim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests work
Sound conversion works, and warnings are shown

@AntiDog AntiDog merged commit efd234e into Catrobat:develop Apr 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants