Fix for at transform: bug
#158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prevents for "at" statements a false end of line colon if followed by a "at transform" line
madeddy
commented
Feb 11, 2024
|
|
||
| # BUG: If there was a "at ..." stmt before a transform, a wrong colon was added. | ||
| # In tests worked this so far | ||
| if not wrote_colon and lineno is not None and not has_block: |
There was a problem hiding this comment.
That's wrong what i did here:
My fix makes the wrong colon gone, but the real reason is the "at transform" in our current case is written 26 lines to late, even after its children if see this right. This causes the wrong colon on the end of the line before it i guess.
I should probably make a issue for this.
This reverts commit 2ad0f08.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ #103 #115 #129