Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GeoJSON polygons with holes #1878

Closed
mramato opened this issue Jul 1, 2014 · 1 comment
Closed

GeoJSON polygons with holes #1878

mramato opened this issue Jul 1, 2014 · 1 comment
Assignees

Comments

@mramato
Copy link
Contributor

mramato commented Jul 1, 2014

I'm working on adding polygons with holes support to the DataSource layer so that GeoJSON, CZML, KML, and others can use it. As a test case, I created this simple geojson file click to view. Hit raw for the text.

Either I'm misunderstanding something or this behavior seems to be incompatible with how we define holes in Cesium. I created this Sandcastle example that uses the same data to try and reproduce the visual, but it's not what I expect. (The geometry is in Sumatra). I'm not sure if this is a bug in our geometry computation or something I'm doing wrong.

Any suggestions? I think the GeoJSON spec does a poor job of defining what is supposed to happen with data like this, but I think it's important we be able to render GeoJSON files the same as Leaflet does; since that's pretty much become the defacto GeoJSON viewer.

Leaflet:
image

Cesium:
image

@mramato
Copy link
Contributor Author

mramato commented Jan 29, 2015

Fixed with #2353, the spec seems to indicate holes like the above are not valid and just a fluke of the leaflet implementation.

@mramato mramato closed this as completed Jan 29, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant