Refactor vertex positions #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to pull out the polygon hierarchy stuff for now, so this nixes 3 in my list above. I still want to add support for holes, but I don't want it coupled to the more urgent need of refactoring vertex positions. I'll let you know when this is ready. #69 still needs to go in before this change. |
1. Remove vertexPositions from Packet 2. Add equivalent `positions` property to Polygon and Polyline holes
|
I was feeling fancy so I did a squash and force push. This is ready to look at. |
| @@ -54,6 +54,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Schema", "Schema", "{04E49F | |||
| ..\Schema\PixelOffset.jsonschema = ..\Schema\PixelOffset.jsonschema | |||
| ..\Schema\Point.jsonschema = ..\Schema\Point.jsonschema | |||
| ..\Schema\Polygon.jsonschema = ..\Schema\Polygon.jsonschema | |||
| ..\Schema\PolygonHierarchy.jsonschema = ..\Schema\PolygonHierarchy.jsonschema | |||
There was a problem hiding this comment.
PolygonHierarchy.jsonschema doesn't exist.
There was a problem hiding this comment.
I'll just remove this and merge.
shunter
added a commit
that referenced
this pull request
Jul 8, 2014
…ions Refactor vertex positions
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this up for early feedback. There is a
vertexPositionsbranch in Cesium that goes along with this (which I'm still working on).vertexPositionsfromPacketpositionsproperty toPolygonandPolylinehierarchyproperty toPolygonto support an arbitrary number of holesKML is broken but I opened #69 to remove it completely.
It's number 3, above, that is causing me issues. I'm not really sure how we want to define polygons with holes in CZML. The GeoJSON way of doing it is probably CZML friendly, but the spec is not very 3D friendly (see CesiumGS/cesium/issues/1878). KML and Cesium have similar rules for defining them but I'm not sure how well that will translate to CZML.
GeoJSON spec for polygon with holes
KML spec for polygon with holes
Cesium doc for polygon with holes
I want to get this into Cesium 1.0 because I think it's important from a backwards compatibility standpoint. Worst case, we can forgo wholes support for now and then add it later (but still move
vertexPositionsdown into the individual objects).@shunter and @kring any thoughts?