Remove prototype functions

[hpinkos]

#1082

Removed prototype functions from:
AxisAlignedBoundingBox, BoundingRectangle, BoundingSphere, Plane, Ray, Spherical

I left in AxisAlignedBoundingBox.prototype.intersect, BoundingRectangle.prototype.intersect and BoundingSphere.prototype.intersect because one of the CullingVolume tests made it look like it was necessary.

[pjcozzi]

I think we are keeping clone and equals prototype functions like, for example, on Cartesian2.

[pjcozzi]

I left in AxisAlignedBoundingBox.prototype.intersect, BoundingRectangle.prototype.intersect and BoundingSphere.prototype.intersect because one of the CullingVolume tests made it look like it was necessary.

Which test? I don't expect we'll need these since we no longer do view frustum culling polymorphically because it was a pain to avoid allocating new objects every frame.

[pjcozzi]

@hpinkos once we merge this, is there anything else you want to do for #1082?

[hpinkos]

Which test? I don't expect we'll need these since we no longer do view frustum culling polymorphically because it was a pain to avoid allocating new objects every frame.

I initially changed line 50 in CullingVolume.js to be BoundingSphere.intersect(boundingVolume, planes[k]), but CullingVolumeSpec tests both a BoundingSphere and an AxisAlignedBoundingBox.

[hpinkos]

once we merge this, is there anything else you want to do for #1082?

@pjcozzi The only other one I noticed that seemed to have a lot of prototype functions is Extent. Do we want to change that?

And this branch is ready for review.

[pjcozzi]

@pjcozzi The only other one I noticed that seemed to have a lot of prototype functions is Extent. Do we want to change that?

Yes, let's do that as a separate pull request and then declare #1082 done.

[pjcozzi]

I initially changed line 50 in CullingVolume.js to be BoundingSphere.intersect(boundingVolume, planes[k]), but CullingVolumeSpec tests both a BoundingSphere and an AxisAlignedBoundingBox.

Ah, OK.

[pjcozzi]

Going off of Cartesian2, shouldn't we leave the prototype versions of equalsEpsilon and toString?

[pjcozzi]

Just those questions. Tests, Sandcastle, and JSHint are good.

[hpinkos]

@pjcozzi anything else?

[pjcozzi]

No, looks good.