Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Less API indirection #2344

Merged
merged 5 commits into from
Dec 23, 2014
Merged

Less API indirection #2344

merged 5 commits into from
Dec 23, 2014

Conversation

pjcozzi
Copy link
Contributor

@pjcozzi pjcozzi commented Dec 23, 2014

From CHANGES.md:

Added the following properties to Viewer and CesiumWidget: imageryLayers, terrainProvider, and camera. This avoids the need to access viewer.scene in some cases.

For #2183. This does not add a primitives property since we want to promote the entity API moving forward. We'll add common properties as needed.

@hpinkos
Copy link
Contributor

hpinkos commented Dec 23, 2014

@pjcozzi I just pushed one case i the terrain example that you missed. but everything else looks good!

hpinkos pushed a commit that referenced this pull request Dec 23, 2014
Merge pull request #2344 from AnalyticalGraphicsInc/viewer-scene
7f8138c 
Less API indirection
@hpinkos hpinkos merged commit 7f8138c into master Dec 23, 2014
@hpinkos hpinkos deleted the viewer-scene branch December 23, 2014 16:24
@pjcozzi
Copy link
Contributor Author

pjcozzi commented Dec 24, 2014

@pjcozzi I just pushed one case i the terrain example that you missed. but everything else looks good!

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjcozzi @hpinkos