Fix race condition in Entity batching. #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2514 (and other related issues as discussed [on the forum](https://groups.google.com/d/msg/cesium-dev/JOUCjnqeFKg/q5aAZb2faAMJ)). The problem was that when static entities were updated, we would create a primitive to batch them. However, if the entities were updated again before the primitive was ready, we didn't remove it.
pjcozzi
added a commit
that referenced
this pull request
Mar 2, 2015
…ndition Fix race condition in Entity batching.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2514 (and other related issues as discussed on the forum).
The problem was that when static entities were updated, we would create a primitive to batch them. However, if the entities were updated again before the primitive was ready, we didn't remove it.
I don't have a good way to unit test this yet, but there is a Sandcastle example in #2514. Moer throughly testing these private classes is on the roadmap, but shouldn't hold up this fix (which lots of people are running into).