Skip to content

Vector Tiles #6097

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 443 commits into from
Jan 8, 2018
Merged

Vector Tiles #6097

merged 443 commits into from
Jan 8, 2018

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jan 8, 2018

This has already been reviewed in #4665. This PR is to merge to master.

Tom Fili and others added 30 commits July 12, 2017 16:40
Fix typo in vector-tiles branch
@cesium-concierge
Copy link

Signed CLA is on file.

@bagnell, thanks for the pull request! Maintainers, we have a signed CLA from @bagnell, so you can review this at any time.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse lilleyse merged commit e03d6ac into master Jan 8, 2018
@lilleyse lilleyse deleted the 3d-tiles-vector branch January 8, 2018 21:24
@mramato
Copy link
Contributor

mramato commented Jan 8, 2018

@bagnell whose account are these sample datasets under? All beta.cesium.com assets in Sandcastle should use the same account so they can be centrally managed.

@bagnell
Copy link
Contributor Author

bagnell commented Jan 8, 2018

They are under my account. I didn't know which the others belonged to. Can you transfer them?

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 8, 2018

I know not all of this is code, but does this set the record for largest Cesium PR?

image

* Added `AttributeCompression.zigZagDeltaDecode` which will decode delta and ZigZag encoded buffers in place.
* Added `pack` and `unpack` functions to `OrientedBoundingBox` for packing to and unpacking from a flat buffer.
* Added `Cesium3DTileset.ellipsoid` determining the size and shape of the globe. This can be set at construction and defaults to a WGS84 ellipsoid.
* Added experimental support for [3D Tiles Vector Data](https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/vector-tiles/TileFormats/VectorData) ([#4665](https://github.com/AnalyticalGraphicsInc/cesium/pull/4665)). The new and modified Cesium APIs are:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And geometry tiles. Please update in master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. 662a833

@bagnell
Copy link
Contributor Author

bagnell commented Jan 8, 2018

I know not all of this is code, but does this set the record for largest Cesium PR?

Nope, but it's up there. The 3D Tiles PR:
3d_tiles_pr

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 8, 2018

Ah, tough competition. 👍

@davidyaha davidyaha mentioned this pull request Jun 3, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants