Skip to content

Align plane entities with ellipsoid surface #6887

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 10, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Aug 6, 2018

Before:
image

After:
image

Thanks @bagnell for figuring out the math for this =)

@ggetz can you review?

@cesium-concierge
Copy link

cesium-concierge commented Aug 6, 2018

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@ggetz
Copy link
Contributor

ggetz commented Aug 9, 2018

Thanks @hpinkos, will look at this soon.

@ggetz
Copy link
Contributor

ggetz commented Aug 9, 2018

Everything looks good, thanks @hpinkos. It is worth re-snapping the Sandcastle thumbnail ?

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 10, 2018

@ggetz updated

@ggetz
Copy link
Contributor

ggetz commented Aug 10, 2018

Thanks!

@ggetz ggetz merged commit f982edf into master Aug 10, 2018
@ggetz ggetz deleted the better-plane-alignment branch August 10, 2018 20:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants