Optimize Geometry Bounding Sphere #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if (typeof boundingSphere !== 'undefined') { | ||
| Cartesian3.divideByScalar(boundingSphere.center, i, boundingSphere.center); |
There was a problem hiding this comment.
Don't use i here. Shouldn't it be i - 1 anyway? Regardless, use length because the semantics are much better.
There was a problem hiding this comment.
Sorry, i is right, but use length instead.
|
Sorry to bikeshed this but I wrote the original code and designed the new algorithm and want to keep the code clean, clean, clean. |
|
@pjcozzi This is ready for another review. |
|
All good. Make sure to keep #766 up to date. |
pjcozzi
added a commit
that referenced
this pull request
Aug 2, 2013
…here Optimize Geometry Bounding Sphere
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the bounding sphere for combined geometry.
Before:
After:
