Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs: remove description prefix from CLI options #6682

Merged
merged 1 commit into from
Apr 19, 2024
Merged

docs: remove description prefix from CLI options #6682

merged 1 commit into from
Apr 19, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Apr 18, 2024

Motivation

It seems unnecessary that we prefix the description with description:, should be clear from context that this is the description of the CLI option, and I think it supports readability to remove it.

With description:

image

Without description:

image

Description

Remove description: prefix from description of CLI options, for everything else the prefix adds important information.

@nflaig nflaig requested a review from a team as a code owner April 18, 2024 10:26
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Merging #6682 (74b294f) into unstable (eb84b49) will not change coverage.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6682   +/-   ##
=========================================
  Coverage     61.80%   61.80%           
=========================================
  Files           556      556           
  Lines         59103    59103           
  Branches       1898     1898           
=========================================
  Hits          36526    36526           
  Misses        22534    22534           
  Partials         43       43

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 899231b Previous: f5148b2 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 858.59 us/op 566.38 us/op 1.52
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 110.28 us/op 105.04 us/op 1.05
BLS verify - blst-native 1.4569 ms/op 1.3367 ms/op 1.09
BLS verifyMultipleSignatures 3 - blst-native 2.9609 ms/op 2.8140 ms/op 1.05
BLS verifyMultipleSignatures 8 - blst-native 6.2071 ms/op 6.1794 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 22.975 ms/op 22.211 ms/op 1.03
BLS verifyMultipleSignatures 64 - blst-native 45.718 ms/op 44.382 ms/op 1.03
BLS verifyMultipleSignatures 128 - blst-native 93.016 ms/op 86.316 ms/op 1.08
BLS deserializing 10000 signatures 971.40 ms/op 906.25 ms/op 1.07
BLS deserializing 100000 signatures 9.6798 s/op 9.2687 s/op 1.04
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.5093 ms/op 1.3740 ms/op 1.10
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.6842 ms/op 1.5319 ms/op 1.10
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.6108 ms/op 2.4246 ms/op 1.08
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.8513 ms/op 3.5064 ms/op 1.10
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.5608 ms/op 5.8519 ms/op 1.12
BLS aggregatePubkeys 32 - blst-native 31.312 us/op 25.941 us/op 1.21
BLS aggregatePubkeys 128 - blst-native 128.04 us/op 101.38 us/op 1.26
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 79.702 ms/op 63.597 ms/op 1.25
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 86.923 ms/op 80.511 ms/op 1.08
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 61.331 ms/op 49.355 ms/op 1.24
getSlashingsAndExits - default max 284.86 us/op 221.03 us/op 1.29
getSlashingsAndExits - 2k 568.88 us/op 472.31 us/op 1.20
proposeBlockBody type=full, size=empty 8.1598 ms/op 6.8600 ms/op 1.19
isKnown best case - 1 super set check 722.00 ns/op 466.00 ns/op 1.55
isKnown normal case - 2 super set checks 773.00 ns/op 524.00 ns/op 1.48
isKnown worse case - 16 super set checks 670.00 ns/op 439.00 ns/op 1.53
InMemoryCheckpointStateCache - add get delete 9.0480 us/op 7.0400 us/op 1.29
validate api signedAggregateAndProof - struct 3.3796 ms/op 2.9167 ms/op 1.16
validate gossip signedAggregateAndProof - struct 3.4263 ms/op 2.8513 ms/op 1.20
validate gossip attestation - vc 640000 1.6526 ms/op 1.4036 ms/op 1.18
batch validate gossip attestation - vc 640000 - chunk 32 199.71 us/op 176.99 us/op 1.13
batch validate gossip attestation - vc 640000 - chunk 64 174.87 us/op 159.14 us/op 1.10
batch validate gossip attestation - vc 640000 - chunk 128 184.25 us/op 154.55 us/op 1.19
batch validate gossip attestation - vc 640000 - chunk 256 167.68 us/op 150.83 us/op 1.11
pickEth1Vote - no votes 1.7321 ms/op 1.5095 ms/op 1.15
pickEth1Vote - max votes 15.781 ms/op 11.698 ms/op 1.35
pickEth1Vote - Eth1Data hashTreeRoot value x2048 30.588 ms/op 21.620 ms/op 1.41
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 36.166 ms/op 33.432 ms/op 1.08
pickEth1Vote - Eth1Data fastSerialize value x2048 860.84 us/op 828.77 us/op 1.04
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.5397 ms/op 6.4259 ms/op 1.48
bytes32 toHexString 712.00 ns/op 819.00 ns/op 0.87
bytes32 Buffer.toString(hex) 343.00 ns/op 315.00 ns/op 1.09
bytes32 Buffer.toString(hex) from Uint8Array 569.00 ns/op 614.00 ns/op 0.93
bytes32 Buffer.toString(hex) + 0x 350.00 ns/op 310.00 ns/op 1.13
Object access 1 prop 0.26900 ns/op 0.24400 ns/op 1.10
Map access 1 prop 0.18200 ns/op 0.16400 ns/op 1.11
Object get x1000 7.9210 ns/op 8.1800 ns/op 0.97
Map get x1000 0.93500 ns/op 0.95900 ns/op 0.97
Object set x1000 80.563 ns/op 84.287 ns/op 0.96
Map set x1000 55.737 ns/op 61.462 ns/op 0.91
Return object 10000 times 0.27220 ns/op 0.28510 ns/op 0.95
Throw Error 10000 times 4.4027 us/op 4.2165 us/op 1.04
fastMsgIdFn sha256 / 200 bytes 3.8520 us/op 3.7510 us/op 1.03
fastMsgIdFn h32 xxhash / 200 bytes 383.00 ns/op 413.00 ns/op 0.93
fastMsgIdFn h64 xxhash / 200 bytes 421.00 ns/op 435.00 ns/op 0.97
fastMsgIdFn sha256 / 1000 bytes 12.835 us/op 12.280 us/op 1.05
fastMsgIdFn h32 xxhash / 1000 bytes 529.00 ns/op 531.00 ns/op 1.00
fastMsgIdFn h64 xxhash / 1000 bytes 522.00 ns/op 547.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 114.63 us/op 114.83 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 2.1570 us/op 2.1830 us/op 0.99
fastMsgIdFn h64 xxhash / 10000 bytes 1.5090 us/op 1.5450 us/op 0.98
send data - 1000 256B messages 24.205 ms/op 27.359 ms/op 0.88
send data - 1000 512B messages 33.166 ms/op 32.180 ms/op 1.03
send data - 1000 1024B messages 50.656 ms/op 48.050 ms/op 1.05
send data - 1000 1200B messages 62.177 ms/op 45.378 ms/op 1.37
send data - 1000 2048B messages 57.736 ms/op 62.919 ms/op 0.92
send data - 1000 4096B messages 51.643 ms/op 56.302 ms/op 0.92
send data - 1000 16384B messages 133.89 ms/op 150.72 ms/op 0.89
send data - 1000 65536B messages 598.32 ms/op 573.16 ms/op 1.04
enrSubnets - fastDeserialize 64 bits 1.9430 us/op 1.7930 us/op 1.08
enrSubnets - ssz BitVector 64 bits 589.00 ns/op 592.00 ns/op 0.99
enrSubnets - fastDeserialize 4 bits 244.00 ns/op 252.00 ns/op 0.97
enrSubnets - ssz BitVector 4 bits 562.00 ns/op 570.00 ns/op 0.99
prioritizePeers score -10:0 att 32-0.1 sync 2-0 258.58 us/op 238.81 us/op 1.08
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 371.83 us/op 369.90 us/op 1.01
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 444.84 us/op 453.47 us/op 0.98
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 749.00 us/op 717.26 us/op 1.04
prioritizePeers score 0:0 att 64-1 sync 4-1 938.51 us/op 900.22 us/op 1.04
array of 16000 items push then shift 1.9221 us/op 1.7660 us/op 1.09
LinkedList of 16000 items push then shift 10.507 ns/op 11.094 ns/op 0.95
array of 16000 items push then pop 131.34 ns/op 129.29 ns/op 1.02
LinkedList of 16000 items push then pop 11.660 ns/op 9.7640 ns/op 1.19
array of 24000 items push then shift 3.0086 us/op 2.6920 us/op 1.12
LinkedList of 24000 items push then shift 11.926 ns/op 11.155 ns/op 1.07
array of 24000 items push then pop 158.85 ns/op 188.23 ns/op 0.84
LinkedList of 24000 items push then pop 10.805 ns/op 9.8030 ns/op 1.10
intersect bitArray bitLen 8 6.8770 ns/op 6.7700 ns/op 1.02
intersect array and set length 8 98.989 ns/op 114.83 ns/op 0.86
intersect bitArray bitLen 128 43.898 ns/op 42.991 ns/op 1.02
intersect array and set length 128 1.1261 us/op 1.2180 us/op 0.92
bitArray.getTrueBitIndexes() bitLen 128 2.0570 us/op 2.2200 us/op 0.93
bitArray.getTrueBitIndexes() bitLen 248 3.4220 us/op 3.6100 us/op 0.95
bitArray.getTrueBitIndexes() bitLen 512 6.7750 us/op 8.3180 us/op 0.81
Buffer.concat 32 items 1.1750 us/op 1.2730 us/op 0.92
Uint8Array.set 32 items 2.2640 us/op 2.3180 us/op 0.98
Set add up to 64 items then delete first 5.3992 us/op 5.5707 us/op 0.97
OrderedSet add up to 64 items then delete first 7.5490 us/op 7.6495 us/op 0.99
Set add up to 64 items then delete last 6.2880 us/op 6.0255 us/op 1.04
OrderedSet add up to 64 items then delete last 7.6463 us/op 7.7540 us/op 0.99
Set add up to 64 items then delete middle 6.3495 us/op 5.7392 us/op 1.11
OrderedSet add up to 64 items then delete middle 9.4495 us/op 9.2501 us/op 1.02
Set add up to 128 items then delete first 11.975 us/op 12.065 us/op 0.99
OrderedSet add up to 128 items then delete first 15.530 us/op 16.048 us/op 0.97
Set add up to 128 items then delete last 12.201 us/op 12.202 us/op 1.00
OrderedSet add up to 128 items then delete last 15.072 us/op 15.219 us/op 0.99
Set add up to 128 items then delete middle 13.355 us/op 11.376 us/op 1.17
OrderedSet add up to 128 items then delete middle 22.602 us/op 21.905 us/op 1.03
Set add up to 256 items then delete first 24.733 us/op 23.504 us/op 1.05
OrderedSet add up to 256 items then delete first 34.445 us/op 34.963 us/op 0.99
Set add up to 256 items then delete last 24.468 us/op 22.940 us/op 1.07
OrderedSet add up to 256 items then delete last 32.272 us/op 30.891 us/op 1.04
Set add up to 256 items then delete middle 24.115 us/op 22.976 us/op 1.05
OrderedSet add up to 256 items then delete middle 59.700 us/op 55.380 us/op 1.08
transfer serialized Status (84 B) 2.2160 us/op 2.2720 us/op 0.98
copy serialized Status (84 B) 1.7830 us/op 1.6690 us/op 1.07
transfer serialized SignedVoluntaryExit (112 B) 2.6310 us/op 2.3460 us/op 1.12
copy serialized SignedVoluntaryExit (112 B) 1.7820 us/op 1.7720 us/op 1.01
transfer serialized ProposerSlashing (416 B) 3.5770 us/op 3.6030 us/op 0.99
copy serialized ProposerSlashing (416 B) 3.4450 us/op 3.5310 us/op 0.98
transfer serialized Attestation (485 B) 3.7510 us/op 3.7960 us/op 0.99
copy serialized Attestation (485 B) 3.4750 us/op 3.0380 us/op 1.14
transfer serialized AttesterSlashing (33232 B) 3.7420 us/op 3.7480 us/op 1.00
copy serialized AttesterSlashing (33232 B) 9.7960 us/op 20.864 us/op 0.47
transfer serialized Small SignedBeaconBlock (128000 B) 3.9140 us/op 5.1360 us/op 0.76
copy serialized Small SignedBeaconBlock (128000 B) 21.846 us/op 36.207 us/op 0.60
transfer serialized Avg SignedBeaconBlock (200000 B) 3.3760 us/op 5.1810 us/op 0.65
copy serialized Avg SignedBeaconBlock (200000 B) 33.442 us/op 60.548 us/op 0.55
transfer serialized BlobsSidecar (524380 B) 4.4000 us/op 6.0200 us/op 0.73
copy serialized BlobsSidecar (524380 B) 286.01 us/op 159.42 us/op 1.79
transfer serialized Big SignedBeaconBlock (1000000 B) 3.7830 us/op 5.8760 us/op 0.64
copy serialized Big SignedBeaconBlock (1000000 B) 169.89 us/op 307.28 us/op 0.55
pass gossip attestations to forkchoice per slot 4.4003 ms/op 5.0232 ms/op 0.88
forkChoice updateHead vc 100000 bc 64 eq 0 765.75 us/op 714.60 us/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 0 6.3651 ms/op 6.8959 ms/op 0.92
forkChoice updateHead vc 1000000 bc 64 eq 0 8.8962 ms/op 7.9774 ms/op 1.12
forkChoice updateHead vc 600000 bc 320 eq 0 4.6926 ms/op 4.6475 ms/op 1.01
forkChoice updateHead vc 600000 bc 1200 eq 0 5.0116 ms/op 4.9942 ms/op 1.00
forkChoice updateHead vc 600000 bc 7200 eq 0 6.3452 ms/op 6.6299 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 1000 12.469 ms/op 12.220 ms/op 1.02
forkChoice updateHead vc 600000 bc 64 eq 10000 14.632 ms/op 14.463 ms/op 1.01
forkChoice updateHead vc 600000 bc 64 eq 300000 19.216 ms/op 54.969 ms/op 0.35
computeDeltas 500000 validators 300 proto nodes 7.7912 ms/op 7.6026 ms/op 1.02
computeDeltas 500000 validators 1200 proto nodes 7.6092 ms/op 7.3888 ms/op 1.03
computeDeltas 500000 validators 7200 proto nodes 6.7714 ms/op 6.9354 ms/op 0.98
computeDeltas 750000 validators 300 proto nodes 10.041 ms/op 10.657 ms/op 0.94
computeDeltas 750000 validators 1200 proto nodes 9.8864 ms/op 10.698 ms/op 0.92
computeDeltas 750000 validators 7200 proto nodes 10.325 ms/op 10.418 ms/op 0.99
computeDeltas 1400000 validators 300 proto nodes 20.803 ms/op 21.535 ms/op 0.97
computeDeltas 1400000 validators 1200 proto nodes 20.322 ms/op 20.608 ms/op 0.99
computeDeltas 1400000 validators 7200 proto nodes 21.361 ms/op 20.142 ms/op 1.06
computeDeltas 2100000 validators 300 proto nodes 34.150 ms/op 30.415 ms/op 1.12
computeDeltas 2100000 validators 1200 proto nodes 32.311 ms/op 31.930 ms/op 1.01
computeDeltas 2100000 validators 7200 proto nodes 33.608 ms/op 33.406 ms/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 3.7081 ms/op 7.9320 ms/op 0.47
altair processAttestation - 250000 vs - 7PWei worstcase 5.0201 ms/op 10.812 ms/op 0.46
altair processAttestation - setStatus - 1/6 committees join 175.91 us/op 412.80 us/op 0.43
altair processAttestation - setStatus - 1/3 committees join 331.57 us/op 812.36 us/op 0.41
altair processAttestation - setStatus - 1/2 committees join 491.59 us/op 1.0978 ms/op 0.45
altair processAttestation - setStatus - 2/3 committees join 568.85 us/op 1.3693 ms/op 0.42
altair processAttestation - setStatus - 4/5 committees join 792.12 us/op 1.7185 ms/op 0.46
altair processAttestation - setStatus - 100% committees join 908.23 us/op 2.0279 ms/op 0.45
altair processBlock - 250000 vs - 7PWei normalcase 9.6302 ms/op 19.435 ms/op 0.50
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.420 ms/op 89.449 ms/op 0.49
altair processBlock - 250000 vs - 7PWei worstcase 55.176 ms/op 77.257 ms/op 0.71
altair processBlock - 250000 vs - 7PWei worstcase hashState 120.17 ms/op 196.50 ms/op 0.61
phase0 processBlock - 250000 vs - 7PWei normalcase 3.7024 ms/op 6.9290 ms/op 0.53
phase0 processBlock - 250000 vs - 7PWei worstcase 44.223 ms/op 58.098 ms/op 0.76
altair processEth1Data - 250000 vs - 7PWei normalcase 713.41 us/op 1.2087 ms/op 0.59
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 18.930 us/op 35.117 us/op 0.54
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 76.192 us/op 148.47 us/op 0.51
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 29.201 us/op 59.735 us/op 0.49
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 18.207 us/op 40.492 us/op 0.45
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 204.37 us/op 321.66 us/op 0.64
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.8896 ms/op 2.7972 ms/op 0.68
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.3322 ms/op 3.9335 ms/op 0.59
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.4930 ms/op 3.3347 ms/op 0.75
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 5.2659 ms/op 12.393 ms/op 0.42
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.4925 ms/op 6.0161 ms/op 0.58
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 7.2022 ms/op 19.883 ms/op 0.36
Tree 40 250000 create 626.71 ms/op 1.6332 s/op 0.38
Tree 40 250000 get(125000) 253.40 ns/op 387.26 ns/op 0.65
Tree 40 250000 set(125000) 1.4509 us/op 5.8199 us/op 0.25
Tree 40 250000 toArray() 26.212 ms/op 59.792 ms/op 0.44
Tree 40 250000 iterate all - toArray() + loop 28.198 ms/op 65.092 ms/op 0.43
Tree 40 250000 iterate all - get(i) 84.481 ms/op 163.02 ms/op 0.52
MutableVector 250000 create 19.996 ms/op 27.365 ms/op 0.73
MutableVector 250000 get(125000) 7.7830 ns/op 11.670 ns/op 0.67
MutableVector 250000 set(125000) 403.43 ns/op 1.0745 us/op 0.38
MutableVector 250000 toArray() 4.9453 ms/op 7.7227 ms/op 0.64
MutableVector 250000 iterate all - toArray() + loop 4.7624 ms/op 8.2208 ms/op 0.58
MutableVector 250000 iterate all - get(i) 1.8578 ms/op 3.0926 ms/op 0.60
Array 250000 create 4.3740 ms/op 6.8597 ms/op 0.64
Array 250000 clone - spread 1.9603 ms/op 7.3420 ms/op 0.27
Array 250000 get(125000) 1.9930 ns/op 4.0960 ns/op 0.49
Array 250000 set(125000) 6.4220 ns/op 7.0830 ns/op 0.91
Array 250000 iterate all - loop 216.94 us/op 218.46 us/op 0.99
effectiveBalanceIncrements clone Uint8Array 300000 77.164 us/op 121.64 us/op 0.63
effectiveBalanceIncrements clone MutableVector 300000 670.00 ns/op 2.6890 us/op 0.25
effectiveBalanceIncrements rw all Uint8Array 300000 236.28 us/op 310.20 us/op 0.76
effectiveBalanceIncrements rw all MutableVector 300000 157.68 ms/op 323.01 ms/op 0.49
phase0 afterProcessEpoch - 250000 vs - 7PWei 136.17 ms/op 176.60 ms/op 0.77
phase0 beforeProcessEpoch - 250000 vs - 7PWei 67.091 ms/op 134.76 ms/op 0.50
altair processEpoch - mainnet_e81889 642.73 ms/op 1.1120 s/op 0.58
mainnet_e81889 - altair beforeProcessEpoch 104.61 ms/op 227.70 ms/op 0.46
mainnet_e81889 - altair processJustificationAndFinalization 22.857 us/op 45.629 us/op 0.50
mainnet_e81889 - altair processInactivityUpdates 8.2762 ms/op 19.414 ms/op 0.43
mainnet_e81889 - altair processRewardsAndPenalties 69.476 ms/op 96.297 ms/op 0.72
mainnet_e81889 - altair processRegistryUpdates 4.5100 us/op 10.440 us/op 0.43
mainnet_e81889 - altair processSlashings 1.0170 us/op 1.8030 us/op 0.56
mainnet_e81889 - altair processEth1DataReset 781.00 ns/op 2.2380 us/op 0.35
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.8111 ms/op 2.7041 ms/op 0.67
mainnet_e81889 - altair processSlashingsReset 5.5990 us/op 11.812 us/op 0.47
mainnet_e81889 - altair processRandaoMixesReset 12.034 us/op 15.698 us/op 0.77
mainnet_e81889 - altair processHistoricalRootsUpdate 1.8830 us/op 3.1170 us/op 0.60
mainnet_e81889 - altair processParticipationFlagUpdates 4.2420 us/op 7.2460 us/op 0.59
mainnet_e81889 - altair processSyncCommitteeUpdates 1.7160 us/op 2.7940 us/op 0.61
mainnet_e81889 - altair afterProcessEpoch 146.14 ms/op 183.83 ms/op 0.79
capella processEpoch - mainnet_e217614 2.9547 s/op 4.8386 s/op 0.61
mainnet_e217614 - capella beforeProcessEpoch 534.98 ms/op 1.0608 s/op 0.50
mainnet_e217614 - capella processJustificationAndFinalization 23.888 us/op 45.954 us/op 0.52
mainnet_e217614 - capella processInactivityUpdates 29.883 ms/op 37.480 ms/op 0.80
mainnet_e217614 - capella processRewardsAndPenalties 629.48 ms/op 984.94 ms/op 0.64
mainnet_e217614 - capella processRegistryUpdates 23.765 us/op 50.644 us/op 0.47
mainnet_e217614 - capella processSlashings 570.00 ns/op 1.7950 us/op 0.32
mainnet_e217614 - capella processEth1DataReset 635.00 ns/op 2.1750 us/op 0.29
mainnet_e217614 - capella processEffectiveBalanceUpdates 5.5515 ms/op 22.927 ms/op 0.24
mainnet_e217614 - capella processSlashingsReset 4.6310 us/op 10.773 us/op 0.43
mainnet_e217614 - capella processRandaoMixesReset 6.4480 us/op 13.542 us/op 0.48
mainnet_e217614 - capella processHistoricalRootsUpdate 748.00 ns/op 2.9160 us/op 0.26
mainnet_e217614 - capella processParticipationFlagUpdates 1.7000 us/op 5.2580 us/op 0.32
mainnet_e217614 - capella afterProcessEpoch 338.68 ms/op 411.99 ms/op 0.82
phase0 processEpoch - mainnet_e58758 692.25 ms/op 681.65 ms/op 1.02
mainnet_e58758 - phase0 beforeProcessEpoch 180.16 ms/op 194.96 ms/op 0.92
mainnet_e58758 - phase0 processJustificationAndFinalization 26.859 us/op 29.893 us/op 0.90
mainnet_e58758 - phase0 processRewardsAndPenalties 92.047 ms/op 72.289 ms/op 1.27
mainnet_e58758 - phase0 processRegistryUpdates 21.552 us/op 16.124 us/op 1.34
mainnet_e58758 - phase0 processSlashings 884.00 ns/op 1.0100 us/op 0.88
mainnet_e58758 - phase0 processEth1DataReset 894.00 ns/op 622.00 ns/op 1.44
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.6992 ms/op 1.2906 ms/op 1.32
mainnet_e58758 - phase0 processSlashingsReset 4.3520 us/op 3.7600 us/op 1.16
mainnet_e58758 - phase0 processRandaoMixesReset 5.3200 us/op 6.3060 us/op 0.84
mainnet_e58758 - phase0 processHistoricalRootsUpdate 583.00 ns/op 588.00 ns/op 0.99
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.8640 us/op 4.6940 us/op 0.82
mainnet_e58758 - phase0 afterProcessEpoch 119.98 ms/op 106.40 ms/op 1.13
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.8258 ms/op 1.4257 ms/op 1.28
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.8237 ms/op 2.1938 ms/op 0.83
altair processInactivityUpdates - 250000 normalcase 26.935 ms/op 38.465 ms/op 0.70
altair processInactivityUpdates - 250000 worstcase 31.067 ms/op 31.807 ms/op 0.98
phase0 processRegistryUpdates - 250000 normalcase 10.927 us/op 20.381 us/op 0.54
phase0 processRegistryUpdates - 250000 badcase_full_deposits 514.17 us/op 574.55 us/op 0.89
phase0 processRegistryUpdates - 250000 worstcase 0.5 152.45 ms/op 234.79 ms/op 0.65
altair processRewardsAndPenalties - 250000 normalcase 81.999 ms/op 65.764 ms/op 1.25
altair processRewardsAndPenalties - 250000 worstcase 76.737 ms/op 103.72 ms/op 0.74
phase0 getAttestationDeltas - 250000 normalcase 12.191 ms/op 12.271 ms/op 0.99
phase0 getAttestationDeltas - 250000 worstcase 12.091 ms/op 13.195 ms/op 0.92
phase0 processSlashings - 250000 worstcase 102.36 us/op 134.19 us/op 0.76
altair processSyncCommitteeUpdates - 250000 184.53 ms/op 189.30 ms/op 0.97
BeaconState.hashTreeRoot - No change 421.00 ns/op 761.00 ns/op 0.55
BeaconState.hashTreeRoot - 1 full validator 160.36 us/op 184.91 us/op 0.87
BeaconState.hashTreeRoot - 32 full validator 1.5155 ms/op 1.7553 ms/op 0.86
BeaconState.hashTreeRoot - 512 full validator 16.443 ms/op 19.088 ms/op 0.86
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 187.81 us/op 188.49 us/op 1.00
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.9367 ms/op 2.4198 ms/op 1.21
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 38.395 ms/op 32.610 ms/op 1.18
BeaconState.hashTreeRoot - 1 balances 175.83 us/op 150.81 us/op 1.17
BeaconState.hashTreeRoot - 32 balances 1.2358 ms/op 1.3751 ms/op 0.90
BeaconState.hashTreeRoot - 512 balances 15.857 ms/op 13.476 ms/op 1.18
BeaconState.hashTreeRoot - 250000 balances 247.73 ms/op 240.96 ms/op 1.03
aggregationBits - 2048 els - zipIndexesInBitList 33.583 us/op 45.848 us/op 0.73
byteArrayEquals 32 85.098 ns/op 84.308 ns/op 1.01
Buffer.compare 32 63.298 ns/op 59.218 ns/op 1.07
byteArrayEquals 1024 2.3252 us/op 2.4922 us/op 0.93
Buffer.compare 1024 78.252 ns/op 80.018 ns/op 0.98
byteArrayEquals 16384 36.808 us/op 34.557 us/op 1.07
Buffer.compare 16384 286.23 ns/op 287.23 ns/op 1.00
byteArrayEquals 123687377 281.52 ms/op 303.31 ms/op 0.93
Buffer.compare 123687377 8.1707 ms/op 12.570 ms/op 0.65
byteArrayEquals 32 - diff last byte 91.630 ns/op 98.967 ns/op 0.93
Buffer.compare 32 - diff last byte 65.316 ns/op 75.029 ns/op 0.87
byteArrayEquals 1024 - diff last byte 2.4265 us/op 2.5268 us/op 0.96
Buffer.compare 1024 - diff last byte 86.458 ns/op 84.220 ns/op 1.03
byteArrayEquals 16384 - diff last byte 38.171 us/op 40.096 us/op 0.95
Buffer.compare 16384 - diff last byte 316.15 ns/op 294.85 ns/op 1.07
byteArrayEquals 123687377 - diff last byte 284.68 ms/op 296.95 ms/op 0.96
Buffer.compare 123687377 - diff last byte 6.9232 ms/op 12.590 ms/op 0.55
byteArrayEquals 32 - random bytes 5.6880 ns/op 7.6330 ns/op 0.75
Buffer.compare 32 - random bytes 67.544 ns/op 67.310 ns/op 1.00
byteArrayEquals 1024 - random bytes 5.6520 ns/op 7.0850 ns/op 0.80
Buffer.compare 1024 - random bytes 65.016 ns/op 71.807 ns/op 0.91
byteArrayEquals 16384 - random bytes 5.5210 ns/op 7.7170 ns/op 0.72
Buffer.compare 16384 - random bytes 66.422 ns/op 78.324 ns/op 0.85
byteArrayEquals 123687377 - random bytes 9.0900 ns/op 17.140 ns/op 0.53
Buffer.compare 123687377 - random bytes 69.700 ns/op 96.990 ns/op 0.72
regular array get 100000 times 48.070 us/op 56.159 us/op 0.86
wrappedArray get 100000 times 47.978 us/op 58.899 us/op 0.81
arrayWithProxy get 100000 times 15.857 ms/op 18.004 ms/op 0.88
ssz.Root.equals 58.050 ns/op 62.096 ns/op 0.93
byteArrayEquals 57.470 ns/op 59.580 ns/op 0.96
Buffer.compare 11.823 ns/op 13.009 ns/op 0.91
shuffle list - 16384 els 8.9586 ms/op 9.5796 ms/op 0.94
shuffle list - 250000 els 133.47 ms/op 148.97 ms/op 0.90
processSlot - 1 slots 17.814 us/op 24.986 us/op 0.71
processSlot - 32 slots 3.5442 ms/op 4.8993 ms/op 0.72
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 67.694 ms/op 75.280 ms/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 2.9514 ms/op 3.0088 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 4.1608 ms/op 4.2934 ms/op 0.97
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3364 ms/op 4.7927 ms/op 0.90
findModifiedValidators - 10000 modified validators 387.78 ms/op 431.38 ms/op 0.90
findModifiedValidators - 1000 modified validators 240.19 ms/op 259.87 ms/op 0.92
findModifiedValidators - 100 modified validators 217.22 ms/op 210.14 ms/op 1.03
findModifiedValidators - 10 modified validators 200.85 ms/op 214.07 ms/op 0.94
findModifiedValidators - 1 modified validators 209.39 ms/op 224.56 ms/op 0.93
findModifiedValidators - no difference 228.26 ms/op 230.81 ms/op 0.99
compare ViewDUs 5.3954 s/op 7.4018 s/op 0.73
compare each validator Uint8Array 2.1014 s/op 2.7749 s/op 0.76
compare ViewDU to Uint8Array 1.6825 s/op 1.7809 s/op 0.94
migrate state 1000000 validators, 24 modified, 0 new 1.0963 s/op 1.2691 s/op 0.86
migrate state 1000000 validators, 1700 modified, 1000 new 1.5689 s/op 1.7469 s/op 0.90
migrate state 1000000 validators, 3400 modified, 2000 new 1.7490 s/op 1.4233 s/op 1.23
migrate state 1500000 validators, 24 modified, 0 new 982.91 ms/op 1.0225 s/op 0.96
migrate state 1500000 validators, 1700 modified, 1000 new 1.3484 s/op 1.3702 s/op 0.98
migrate state 1500000 validators, 3400 modified, 2000 new 1.3838 s/op 1.4702 s/op 0.94
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5500 ns/op 4.5000 ns/op 1.01
state getBlockRootAtSlot - 250000 vs - 7PWei 591.70 ns/op 527.42 ns/op 1.12
computeProposers - vc 250000 9.2075 ms/op 9.5596 ms/op 0.96
computeEpochShuffling - vc 250000 130.46 ms/op 127.28 ms/op 1.02
getNextSyncCommittee - vc 250000 153.24 ms/op 167.16 ms/op 0.92
computeSigningRoot for AttestationData 28.571 us/op 25.338 us/op 1.13
hash AttestationData serialized data then Buffer.toString(base64) 2.3983 us/op 2.4253 us/op 0.99
toHexString serialized data 1.1414 us/op 1.2787 us/op 0.89
Buffer.toString(base64) 232.27 ns/op 250.39 ns/op 0.93

by benchmarkbot/action

@nflaig nflaig merged commit d145724 into unstable Apr 19, 2024
20 checks passed
@nflaig nflaig deleted the nflaig/remove-description-prefix branch April 19, 2024 08:45
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflaig @wemeetagain @twoeths