-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add tests workflow for bun and deno #423
Conversation
1d52066
to
dac0775
Compare
while I see the improvement on the source code, like not to import I guess we need to put this on hold until we have final approach on which javascript runtime that lodestar want to experiment ChainSafe/lodestar#7237 |
Deno is needed/recommended to publish packages to jsr.io which is intention to test with deno first in this PR. And here is the details that why I am moving to support jsr.io https://jsr.io/docs/why |
Does Bun support jsr.io? if yes I'd go with Bun as we'll most likely to go with it. Again, need to wait for the final decision on ChainSafe/lodestar#7237 if both NodeJS + Bun don't support jsr.io, only Deno does then we need to see if it's a must to support jsr.io. I found it weird to target Bun/NodeJS while having Deno specific resources in the repo |
jsr.io is a registry developed and maintained by Bun for typescript based packages. As it follow modern standards it's compatible with all runtimes. As it's mentioned on there website.
|
3a8fecf
to
c1caf53
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
deafe85
to
8ab2076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
Make the packages compatible with Deno+Bun.
Description
Steps to test or reproduce