-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Potential fixes on Reown and Metmask #1274
Open
kantagara
wants to merge
4
commits into
dev
Choose a base branch
from
nikola/reown-fixes
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
424b290
to
7a39f99
Compare
762d0c4
to
a9abb2c
Compare
7a39f99
to
9c53abd
Compare
bc45c43
to
4d44a5a
Compare
8f12ddb
to
ef5fef1
Compare
juans-chainsafe
suggested changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch network is working as expected again! Please check this video to see that is working, it also does a mint of ERC20:
ScreenRecording_01-27-2025.10-28-04_1.MP4
We have 2 small issues:
- Merge conflicts
- Build error:
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Web3AuthProvider.cs(91,31): error CS0012: The type 'EthECKey' is defined in an assembly that is not referenced. You must add a reference to assembly 'Nethereum.Signer, Version=4.26.0.0, Culture=neutral, PublicKeyToken=null'.
Assets/Tests/Anvil/AnvilProvider.cs(23,27): error CS0012: The type 'EthECKey' is defined in an assembly that is not referenced. You must add a reference to assembly 'Nethereum.Signer, Version=4.26.0.0, Culture=neutral, PublicKeyToken=null'.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this also HEAVILY depends on Metamasks latest version which I don't know when will be released.
It should close #1264