-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for PDF/UA form field #47
Conversation
WalkthroughA new method Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MergeOfficeBuilder
participant MergeOfficeRequest
participant MergeOfficeRequestExtensions
User->>MergeOfficeBuilder: EnablePdfUa()
MergeOfficeBuilder->>MergeOfficeRequest: Set EnablePdfUa to true
MergeOfficeRequest->>MergeOfficeRequestExtensions: Call PropertiesToHttpContent
alt EnablePdfUa is true
MergeOfficeRequestExtensions->>MergeOfficeRequestExtensions: Add PDF/UA conversion form data
end
MergeOfficeRequestExtensions-->>MergeOfficeRequest: Return HTTP content
MergeOfficeRequest-->>MergeOfficeBuilder: Return updated request
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- lib/Domain/Builders/MergeOfficeBuilder.cs (1 hunks)
- lib/Domain/Requests/MergeOfficeRequest.cs (1 hunks)
- lib/Extensions/MergeOfficeRequestExtensions.cs (1 hunks)
- lib/Infrastructure/Constants.cs (1 hunks)
Files skipped from review due to trivial changes (1)
- lib/Infrastructure/Constants.cs
Additional comments not posted (3)
lib/Extensions/MergeOfficeRequestExtensions.cs (1)
43-47
: Ensure correct form data for PDF/UA conversion.The new conditional block correctly adds form data for PDF/UA conversion when
EnablePdfUa
is true. Ensure thatConstants.Gotenberg.LibreOffice.Routes.Convert.PdfUa
is correctly defined and used elsewhere in the codebase.lib/Domain/Builders/MergeOfficeBuilder.cs (1)
93-100
: Confirm the addition of theEnablePdfUa
method.The new method correctly sets the
EnablePdfUa
property in the request object to true. Ensure that this method is adequately tested and used where necessary.lib/Domain/Requests/MergeOfficeRequest.cs (1)
64-67
: Confirm the addition of theEnablePdfUa
property.The new property
EnablePdfUa
is correctly added to enable Universal Access for the resulting PDF. Ensure that this property is adequately tested and used where necessary.
Would fix #46
Summary by CodeRabbit
New Features
Improvements