Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for customer(s) lookup #16

Closed
brownac opened this issue Jun 18, 2019 · 4 comments
Closed

Support for customer(s) lookup #16

brownac opened this issue Jun 18, 2019 · 4 comments
Assignees
@brownac
Labels
enhancement New feature or request

Comments

@brownac
Copy link
Contributor

brownac commented Jun 18, 2019 •
edited
Loading

I noticed that the latest version of the SDK has support for updating customer information. It would be great to have methods called getCustomers() and getCustomer(String id) or something of that nature that fetch all customers and individual customer details based on an e-mail or an ID. It would also be nice to extend this support to the customer search endpoint in case you need to search for a customer based on some other attribute than ID.
@ryankazokas ryankazokas added the help wanted Extra attention is needed label Jun 18, 2019
@brownac
Copy link
Contributor Author

brownac commented Jun 18, 2019

(by the way, I'm happy to take this up!)

@ryankazokas ryankazokas removed the help wanted Extra attention is needed label Jun 18, 2019
@ryankazokas
Copy link
Member

Awesome. Thanks @brownac . PR's are welcome.

@ryankazokas ryankazokas added the enhancement New feature or request label Jun 18, 2019
@brownac brownac mentioned this issue Jun 21, 2019
Merged
@rjdavis3
Copy link
Member

Thanks for your PR @brownac. Your changes are now part of the 1.6.0-SNAPSHOT. We should be releasing 1.6.0 early next week. Sorry for the delay.

cc: @ryankazokas

@rjdavis3
Copy link
Member

rjdavis3 commented Oct 7, 2019

This has been handled by the 1.6.0 release.

@rjdavis3 rjdavis3 closed this as completed Oct 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@brownac brownac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rjdavis3 @ryankazokas @brownac