-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add single and multiple customer lookup and support customer search API #17
Conversation
add back single class imports fix ordering add back single import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brownac well done! Much appreciated PR. Let's discuss some of these changes and then we can move towards merging.
Also, making a mental note to myself here to re-add all the class imports and turn off wildcard importing in IntelliJ. |
@ryankazokas , I made some changes. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brownac The only thing i'd suggest before we merge is do remove the reflection implementation in favor of just adding the query parameters in the getCustomer method if the values in the request object are not blank or null. After that and removing the new bean utils dependency from the POM I will give approval to merge.
Are you manually adding the jar to your project? That might be causing downsstream dependencies not to be loaded into your project. We are using this as well and haven't seen this problem. Could it be possible that the new dependency you added is conflicting with something else? Since we will remove the reflection implementation we won't need that anymore. Try it again after that. I'll load up your branch locally and see if i have the same problem.
@ryankazokas seeming to have trouble getting my build to pass due to mutation coverage % being at 85 (threshold is 87). Do you mind building my branch/leaving any suggestions as to how I can raise it? Edit: actually maybe not? |
@ryankazokas were you ever able to replicate this? |
@brownac can you change the destination branch to develop? |
I was not able to replicate this @brownac . |
@ryankazokas I changed the base branch. Also, I figured out the issue. Turns out my project was using a mismatched version of |
First pass at implementing #16 .
I followed the admin API spec pretty closely. Happy to add/remove support for certain params as you all see fit. Also happy to expand the support for
customerSearch
to include additional params outside ofquery
.Let me know what you all think. Have a good weekend!