Add 😋 as a positive emoji

[syvb]

😋 -- 😋 is considered a positive emoji. On the GitHub website, the face is clearly smiling.

[PlasmaPower]

⛔ Please downvote this, smittyvb will likely try to sneak in dictatorship like I did. That's what their last PR was.

Also the emote isn't that useful.

[yet-another-account]

Hmm, there's not ZWSPs or anything sneaky in there that i could find. Seems okay...

[reddraggone9]

See also, #297. This is okay for now, no gurantees though. If you really want 😋, it would probably be a good idea to hold your vote 'til near the end of the window and watch it merge.

[PlasmaPower]

Yeah, I think smittyvb is trying to execute the amend attack here. As long as we don't give them too many votes it should be fine.

[yet-another-account]

I get the hexdump of this file, and it's perfectly fine. There is absolutely nothing wrong with this commit itself, unless the exploit code was put in earlier and this just triggers it or something like that.

eukaryote@ubuntu-server:~/Chaos/data$ cat emojis.positive | xxd
00000000: 3a2b 313a 0a3a 7468 756d 6273 7570 3a0a  :+1:.:thumbsup:.
00000010: 3a74 6875 6d62 735f 7570 3a0a 3a74 6875  :thumbs_up:.:thu
00000020: 6d62 735f 7570 3a3a 6461 726b 5f73 6b69  mbs_up::dark_ski
00000030: 6e5f 746f 6e65 3a0a 3a74 6875 6d62 735f  n_tone:.:thumbs_
00000040: 7570 3a3a 6c69 6768 745f 736b 696e 5f74  up::light_skin_t
00000050: 6f6e 653a 0a3a 7468 756d 6273 5f75 703a  one:.:thumbs_up:
00000060: 3a6d 6564 6975 6d2d 6461 726b 5f73 6b69  :medium-dark_ski
00000070: 6e5f 746f 6e65 3a0a 3a74 6875 6d62 735f  n_tone:.:thumbs_
00000080: 7570 3a3a 6d65 6469 756d 2d6c 6967 6874  up::medium-light
00000090: 5f73 6b69 6e5f 746f 6e65 3a0a 3a74 6875  _skin_tone:.:thu
000000a0: 6d62 735f 7570 3a3a 6d65 6469 756d 5f73  mbs_up::medium_s
000000b0: 6b69 6e5f 746f 6e65 3a0a 3a68 6561 7274  kin_tone:.:heart
000000c0: 3a0a 3a74 776f 5f68 6561 7274 733a 0a3a  :.:two_hearts:.:
000000d0: 626c 7565 5f68 6561 7274 3a0a 3a70 7572  blue_heart:.:pur
000000e0: 706c 655f 6865 6172 743a 0a3a 6772 6565  ple_heart:.:gree
000000f0: 6e5f 6865 6172 743a 0a3a 7965 6c6c 6f77  n_heart:.:yellow
00000100: 5f68 6561 7274 3a0a 3a68 6561 7274 7075  _heart:.:heartpu
00000110: 6c73 653a 0a3a 7370 6172 6b6c 696e 675f  lse:.:sparkling_
00000120: 6865 6172 743a 0a3a 7461 6461 3a0a 3a68  heart:.:tada:.:h
00000130: 6f6f 7261 793a 0a3a 6865 6172 745f 6579  ooray:.:heart_ey
00000140: 6573 3a0a 3a67 7269 6e3a 0a3a 6772 696e  es:.:grin:.:grin
00000150: 6e69 6e67 3a0a 3a6a 6f79 3a0a 3a6f 6b5f  ning:.:joy:.:ok_
00000160: 6861 6e64 3a0a 3a66 6972 653a 0a3a 6d65  hand:.:fire:.:me
00000170: 7461 6c3a 0a3a 7261 6973 6564 5f68 616e  tal:.:raised_han
00000180: 6473 3a0a 3a31 3030 3a0a 3a68 6561 7679  ds:.:100:.:heavy
00000190: 5f63 6865 636b 5f6d 6172 6b3a 0a3a 7768  _check_mark:.:wh
000001a0: 6974 655f 6368 6563 6b5f 6d61 726b 3a0a  ite_check_mark:.
000001b0: 3a62 616c 6c6f 745f 626f 785f 7769 7468  :ballot_box_with
000001c0: 5f63 6865 636b 3a0a 3a61 6363 6570 743a  _check:.:accept:
000001d0: 0a3a 636f 6e67 7261 7475 6c61 7469 6f6e  .:congratulation
000001e0: 733a 0a3a 7975 6d3a 0a                   s:.:yum:.

[PlasmaPower]

@eukaryote31 no that's not the problem, I'm saying that smittyvb will likely amend the commit and add malicious code after gathering votes. So exactly what I did.

[yet-another-account]

@PlasmaPower won't that reset the voting window?

[reddraggone9]

It will reset the window, but not the votes. Then the PR will be way down the list so new people won't look at it and the people who voted won't be paying attention anymore.

[PlasmaPower]

@eukaryote31 Yes, but like in my attack, smittyvb hopes people won't notice or won't change their vote in time.

[PlasmaPower]

Anyway, it should be fine as long as we don't go too far over the threshold in votes.

[yet-another-account]

But then that makes all approved PRs potentially dangerous.

[reddraggone9]

Yep. I've been saying this since the change was first made.

[PlasmaPower]

Without the change though you have #48 attacks. I guess for optimal security only negative votes would be preserved, but that makes stuff really hard to merge after changes.

[reddraggone9]

Yeah, @MINIMAN10000 mentioned something like that here.

[reddraggone9]

I should mention that #48 wouldn't be possible with the current threshold, even without the voting changes.

[PlasmaPower]

Oh, good point.

[chaosbot]

🙅 PR rejected with a vote of 5 for and 1 against, with a weighted total of 4.0 and a threshold of 6.1.

Open a new PR to restart voting.