Removed methods and properties deprecated in 1.0 #2996
Conversation
These were only being used by deprecated methods.
Codecov Report
@@ Coverage Diff @@
## master #2996 +/- ##
==========================================
+ Coverage 19.45% 19.99% +0.53%
==========================================
Files 113 113
Lines 16044 15617 -427
Branches 247 247
==========================================
Hits 3122 3122
+ Misses 12884 12457 -427
Partials 38 38
Continue to review full report at Codecov.
|
|
have you checked what's the last date when adding those deprecated tag, I remember it was when Chart 3.0 released? I'm ok to remove them. BTW, it has conflicts :) |
|
I looked for a bit, but gave up looking for the merge. They are marked as deprecated in 1.0, so it doesn't make sense to me that they would be introduced in 3.0. |
|
It was a misunderstanding on what the number there meant. It only applies to OS versions. It doesn’t read our frameworks version. They could have been deprecated in 2.0 or 3.0 I don’t know when though. |
|
but we can remove them now, right? |
|
Searching through the commits I've found that these methods were all deprecated between Apr 8, 2016 and Sept 21, 2016. If we aren't removing them right now, can we mark this for 4.0.0 |
|
|
||
| /// MARK: - Bridging functions | ||
|
|
||
| internal class func bridgedObjCGetNSUIColorArray (swift array: [NSUIColor?]) -> [NSObject] |
There was a problem hiding this comment.
These only existed to support the deprecated functions. Since I am removing the deprecated functions in this PR, these methods are no longer needed.
There was a problem hiding this comment.
Also, this could have been written as let myObjArray = myColorArray as! [NSObject]
|
I'm supporting, like after we finish refactoring and some other enhancements and make a major release, since many things changed and seems it's the right time to remove those APIs |
|
@jjatie will your future commits involve these deprecated methods? If so, I favor to merge soon. |
|
My other PRs don't touch these deprecated methods at all. If we are not merging soon, then this should be in 4.0.0. Given the deprecations are between 14 and 20 months old, I think it's acceptable to do this before 4.0.0 |
|
OK, I will hold this for the moment, we shall have a release after the refinement, so just a matter of time and order. |
|
shall we merge this now or for 4.0, as #3034 has changing some. |
|
merging this, to make things easier. |
* 'master' of https://github.com/danielgindi/Charts: (23 commits) Update ViewPortHandler.swift (ChartsOrg#3143) add option to build demo projects unit tests on iOS (ChartsOrg#3121) Replaced relevant `ChartUtils` methods with `Double` extensions (ChartsOrg#2994) Update 4.0.0 with master (ChartsOrg#3135) Removed redundant ivars in BarLineChartViewBase (ChartsOrg#3043) fix ChartsOrg#1830. credit from ChartsOrg#2049 (ChartsOrg#2874) Makes ChartsDemo compiling again (ChartsOrg#3117) Fixed using wrong axis (Issue ChartsOrg#2257) Removed methods and properties deprecated in 1.0 (ChartsOrg#2996) for ChartsOrg#3061 revert animationUpdate() and animationEnd() not trigger crash if subclass does nothing The backing var is not necessary. (ChartsOrg#3000) Replaced `ChartUtils.Math` in favour of an extension on `FloatingPoint` (ChartsOrg#2993) Minor logic cleanup (ChartsOrg#3041) Fix a bug may cause infinite loop. (ChartsOrg#3073) for ChartsOrg#2745. chart should be weak. fileprivate -> private (ChartsOrg#3042) Removed `isKind(of:)` Removed @objc from internal properties Fixes for PR Made use of `==` where appropriate to simplify logic ... # Conflicts: # Source/Charts/Data/Implementations/Standard/LineChartDataSet.swift # Source/Charts/Renderers/BarChartRenderer.swift
* 'master' of https://github.com/danielgindi/Charts: (34 commits) Fixed X-Axis Labels Not Showing (ChartsOrg#3154) (ChartsOrg#3174) fix programatical unhighlighting for BarCharView (ChartsOrg#3159) Give the users customizable axis label limits (Fixes ChartsOrg#2085) (ChartsOrg#2894) bump pod version chart views now use open legend renderer property instead of internal one (ChartsOrg#3149) Fix axis label disappear when zooming in deep enough (ChartsOrg#3132) added DataApproximator+N extension (ChartsOrg#2848) Minor cleanup to Highlighter types (ChartsOrg#3003) Refactored ChartUtils method into CGPoint extension (ChartsOrg#3087) Update ViewPortHandler.swift (ChartsOrg#3143) add option to build demo projects unit tests on iOS (ChartsOrg#3121) Replaced relevant `ChartUtils` methods with `Double` extensions (ChartsOrg#2994) Update 4.0.0 with master (ChartsOrg#3135) Removed redundant ivars in BarLineChartViewBase (ChartsOrg#3043) fix ChartsOrg#1830. credit from ChartsOrg#2049 (ChartsOrg#2874) Makes ChartsDemo compiling again (ChartsOrg#3117) Fixed using wrong axis (Issue ChartsOrg#2257) Removed methods and properties deprecated in 1.0 (ChartsOrg#2996) for ChartsOrg#3061 revert animationUpdate() and animationEnd() not trigger crash if subclass does nothing The backing var is not necessary. (ChartsOrg#3000) ... # Conflicts: # Source/Charts/Data/Implementations/Standard/LineChartDataSet.swift # Source/Charts/Highlight/BarHighlighter.swift # Source/Charts/Renderers/BarChartRenderer.swift
These produce quite a bit of clutter.
It has been 2-3 years since their deprecation, it seems reasonable to remove them now.
If this is not to be accepted now, when is a good time to resubmit this PR?