for #3061 fix animation crash #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjatie
approved these changes
Dec 14, 2017
Closed
Codecov Report
@@ Coverage Diff @@
## master #3098 +/- ##
=======================================
Coverage 19.46% 19.46%
=======================================
Files 113 113
Lines 15995 15995
Branches 248 248
=======================================
Hits 3114 3114
Misses 12845 12845
Partials 36 36
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #3061
revert animationUpdate() and animationEnd()
not trigger crash if subclass does nothing