Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed using wrong axis (Issue #2257) #3114

Merged
merged 1 commit into from
Dec 25, 2017

Conversation

defranke
Copy link
Contributor

Fix for Issue #2257

@codecov-io
Copy link

codecov-io commented Dec 18, 2017

Codecov Report

Merging #3114 into master will increase coverage by 2.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3114      +/-   ##
==========================================
+ Coverage      20%   22.73%   +2.73%     
==========================================
  Files         113      115       +2     
  Lines       15568    15891     +323     
  Branches      248      280      +32     
==========================================
+ Hits         3114     3613     +499     
+ Misses      12418    12242     -176     
  Partials       36       36
Impacted Files Coverage Δ
...ts/Renderers/XAxisRendererHorizontalBarChart.swift 0% <0%> (ø) ⬆️
Source/Charts/Charts/BarLineChartViewBase.swift 21.31% <0%> (-1.21%) ⬇️
Tests/Charts/CombinedChartTests.swift 100% <0%> (ø)
Tests/Charts/EquatableTests.swift 100% <0%> (ø)
.../Charts/Formatters/DefaultAxisValueFormatter.swift 56.66% <0%> (+0.06%) ⬆️
Source/Charts/Components/Legend.swift 55.82% <0%> (+0.8%) ⬆️
...ource/Charts/Formatters/DefaultFillFormatter.swift 6.55% <0%> (+0.89%) ⬆️
...urce/Charts/Formatters/DefaultValueFormatter.swift 56.6% <0%> (+1.88%) ⬆️
.../Implementations/Standard/ChartDataEntryBase.swift 17.1% <0%> (+9.21%) ⬆️
...arts/Data/Implementations/Standard/ChartData.swift 39.47% <0%> (+9.39%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdd295...88f1811. Read the comment docs.

@liuxuan30 liuxuan30 self-assigned this Dec 19, 2017
@liuxuan30 liuxuan30 self-requested a review December 19, 2017 12:22
Copy link
Member

@liuxuan30 liuxuan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my side.

@liuxuan30
Copy link
Member

liuxuan30 commented Dec 25, 2017

I found another issue while testing, the label sometimes disappeared when zoomed in only one full bar remains on the screen. I add a fix #3132

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants