fix: don't block with update prompt on macos/linux (#5818)

Chatterino · Jan 12, 2025 · 7b33560 · 7b33560
1 parent ae964be
commit 7b33560
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 - Minor: Remove incognito browser support for `opera/launcher` (this should no longer be a thing). (#5805)
 - Minor: Remove incognito browser support for `iexplore`, because internet explorer is EOL. (#5810)
 - Bugfix: Fixed a crash relating to Lua HTTP. (#5800)
+- Bugfix: Fixed a crash that could occur on Linux and macOS when clicking "Install" from the update prompt. (#5818)
 - Bugfix: Fixed missing word wrap in update popup. (#5811)
 - Dev: Updated Conan dependencies. (#5776)
 

diff --git a/src/singletons/Updates.cpp b/src/singletons/Updates.cpp
@@ -125,15 +125,15 @@ void Updates::installUpdates()
         QMessageBox::Information, "Chatterino Update",
         "A link will open in your browser. Download and install to update.");
     box->setAttribute(Qt::WA_DeleteOnClose);
-    box->exec();
+    box->open();
     QDesktopServices::openUrl(this->updateExe_);
 #elif defined Q_OS_LINUX
     QMessageBox *box =
         new QMessageBox(QMessageBox::Information, "Chatterino Update",
                         "Automatic updates are currently not available on "
-                        "linux. Please redownload the app to update.");
+                        "Linux. Please redownload the app to update.");
     box->setAttribute(Qt::WA_DeleteOnClose);
-    box->exec();
+    box->open();
     QDesktopServices::openUrl(this->updateGuideLink_);
 #elif defined Q_OS_WIN
     if (Modes::instance().isPortable)