consolidate firefox incognitobrowser logic (and deprecate opera/launcher)

[teknsl]

Mozilla’s firefox-nightly apt package now points to firefox-bin in its desktop file, catch all firefox variants by mozilla with one if statement

not sure what the changelog should be

[github-actions]

clang-tidy made some suggestions

[pajlada]

Just some nits, will test better later.

Changelog could be:

• Minor: Treat all browsers starting with the filename firefox as Firefox browsers

[teknsl]

it would be possible to just do .startsWith in the loop instead of == now with basename being used, then the ifdef can be removed and a single firefox entry will do in the table and no if statement needed for it

on second thought too easy for conflicts

[Mm2PL]

Mozilla’s firefox-nightly apt package now points to firefox-bin in its desktop file, catch all firefox variants by mozilla with one if statement

How long will it take for all potential distributions to use this? When will this change land in stable packages?

[teknsl]

the desktop file provided by the package (/usr/share/applications/firefox-nightly.desktop) effectively points to /usr/bin/firefox-nightly which is a symlink to /usr/lib/firefox-nightly/firefox-bin, the original behaviour has no problem with this but it seems when you click make default browser in firefox it creates a new desktop file under ~/.local/share/applications/userapp-Nightly-XXXXXX.desktop (or XDG_DATA_HOME) which will point to /usr/lib/firefox-nightly/firefox-bin (and is made default)

not sure if this is new or old behavior ill try to test

this "new" behaviour is present in the firefox (133.0.3) firefox-esr (128.6.0) packages from mozilla but is not in the packages firefox-esr (128.6.0) firefox (134.0-1) from debian unstable

[github-actions]

clang-tidy made some suggestions