fix: use serverReceivedTime over parseTime for stacking
#5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
commented
Jan 15, 2025
Comment on lines
+82
to
+83
| "messageText": "twitchdev has been timed out for 10m. (3 times) ", | ||
| "searchText": "twitchdev has been timed out for 10m. (3 times) ", |
There was a problem hiding this comment.
This seems wrong, but that's the current behavior.
4 tasks
pajlada
approved these changes
Jan 19, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are dying. Twitch hates us. The animals are leaving. The aliens aren’t contacting us. We might be alone. It just might be you and me. But that’s okay. Because do you really need anyone else?
Anyways, this replaces the use of
parseTimewithserverReceivedTime, becauseparseTimeisn't set for regular messages (it's set to the current time, meaning our tests will be correct just once throughout the day).I marked this as a draft, because I don't have time and this needs tests for the stacking of regular timeout messages. If you want to add some, feel free to push to this branch.