refactor: merge adjecent words into one TextElement
#5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: this turns
[{[foo]}, {[bar]}, {[baz]}]into[{[foo, bar, baz]}].I don't think I mentioned this here, but I wasn't happy with
TextElements being created for every word in a message. Especially because many messages in Twitch chat are mostly text. This wastes about 128B/word, plus an allocation for theQStringListwith one element (24B - one string). We can do better! We can append words to existing text elements if they're eligible. A word is eligible if it would've been added with the same flags, color and style.Because we have the new snapshot tests, you can see the result right here (I hope I didn't miss anything).