feat: prefer visible/selected channels when joining #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
requested changes
Jan 23, 2025
pajlada
approved these changes
Jan 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we join channels because Chatterino (re-)connected, the join requests for channels that are currently selected are now put first. When starting Chatterino, this makes it seem like it's faster than before (even though it's as fast as before).
One downside of this PR is that
TwitchIrcServernow knows aboutWindowManager,Window,SplitNotebook,SplitContainer, andSplit.An alternative would be to track the selected channels somewhere (i.e. add/remove them from methods in
SplitorSplitNotebook). I think that approach is more complex with little to no benefit.When searching for
joinBucket_inTwitchIrcServer, you might find another use. We don't call this when starting Chatterino, because the windows are initialized before the IRC connections (the connection isn't connected yet).