Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add feature: auto-discovery for nvidia-smi on linux #722

Closed

Conversation

mayrstefan
Copy link
Contributor

New PR because #680 was closed

General information

There is already support for nvidia-smi on Windows (see Werk 14723). This adds the same section to the linux agent if nvidia-smi is installed

Proposed changes

Add 'nvidia_smi' section to linux agent if nvidia-smi binary is found in path

There is already support for nvidia-smi on Windows. This adds the same section to the linux agent if nvidia-smi is installed
@NikCheckmk
Copy link

Hi mayrstefan,

Thanks a lot for your pull request.

While we definitely see the use case behind it, we'd kindly ask you for your understanding that we have to decline it since this piece of functionality should be implemented as an agent plugin, not as a "native" section of the agent itself. This is for two reasons:

  • Consistency: On Windows, it's implemented as a plugin as well.
  • Compatibility: The agent should only use commands for programs which are expected to be available on a large number of target systems. This is not necessarily the case with nvidia-smi.

We'd be happy to receive an updated version of your code with these changes applied. For organizational reasons however, we can't handle this in the course of this very pull request, but will have to ask you for creating a new one.

Thanks for your understanding.

Best,

Nik

@NikCheckmk NikCheckmk closed this Sep 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants