-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix package reference in export.socrata
#140
Comments
@tomschenkjr I can't add this to 1.7.4 because the code is only in branch |
Got it, so only related to #126? I've reassigned this issue to the v1.8.0 milestone. Since you're looking at it, can you make the change in |
geneorama
added a commit
that referenced
this issue
Dec 4, 2017
I'm not sure why that commit message didn't close this issue, but I'm closing it now. |
Got it. For commit-based closures, it only takes effect when it’s on the master branch. So, eventually it would have closed.
From: Gene Leynes [mailto:notifications@github.com]
Sent: Monday, December 04, 2017 1:47 PM
To: Chicago/RSocrata <RSocrata@noreply.github.com>
Cc: Schenk, Tom <Tom.Schenk@cityofchicago.org>; Mention <mention@noreply.github.com>
Subject: Re: [Chicago/RSocrata] Fix package reference in `export.socrata` (#140)
I'm not sure why that commit message didn't close this issue, but I'm closing it now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#140 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABkC0c3QbfPy4tTmsyefG_yG9ACJae87ks5s9EwfgaJpZM4NbnN7>.
…________________________________
This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Adding issue per discussion in analytics meeting today
export.socrata
has a call tofile_ext
, but it should betools::file_ext
because tools is not in the default search path. https://github.com/Chicago/RSocrata/blob/dev/R/RSocrata.R#L508I think it's sufficient to simply add
tools::
because tools is a default package. I don't think it needs to be added in theIMPORTS
orDEPENDS
fields inDESCRIPTION
.The text was updated successfully, but these errors were encountered: