Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

kernel 事件没有被监听 #44

Closed
songguangyu opened this issue Nov 27, 2017 · 4 comments
Closed

kernel 事件没有被监听 #44

songguangyu opened this issue Nov 27, 2017 · 4 comments
Assignees
@toxic-johann
Labels
fixed

Comments

@songguangyu
Copy link
Member

事件方法参见链接
https://github.com/Chimeejs/chimee-kernel
@toxic-johann toxic-johann self-assigned this Nov 27, 2017
@toxic-johann
Copy link
Member

https://github.com/Chimeejs/chimee/blob/master/src/helper/const.js#L100-L102

具体代码所在地。

@songguangyu
Copy link
Member Author

done，辛苦随下次小版本发布。

@songguangyu songguangyu reopened this Nov 27, 2017
@songguangyu
Copy link
Member Author

发布在close吧

@toxic-johann
Copy link
Member

toxic-johann commented Nov 27, 2017 •
edited
Loading

看了下代码，问题还有点多。原来之前 kernelEvents 没有用到。

  • 绑定事件
  • 解绑事件
  • silentload 切换时的动态重绑
  • error 事件处理
  • silentload 前期对 new kernel 的 error 处理
  • 单元测试通过

@toxic-johann toxic-johann added doing and removed todo labels Nov 28, 2017
toxic-johann pushed a commit that referenced this issue Nov 28, 2017
[fix] fix [#44](#44)
da4b85c 
what: add eventlistener on kernel
why: kernel will dispatch it's own event
how:
1. listen on the event when we create the kernel
2. remove event listener before we destroy the kernel
3. make a event switch when we switch kernel
4. we need to add event binding in silentload before kernel switch
toxic-johann pushed a commit that referenced this issue Nov 28, 2017
[build] 0.6.2
102dca8 
fix bug described in [#44](#44)
@toxic-johann toxic-johann added fixed and removed doing labels Nov 28, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@toxic-johann toxic-johann

Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toxic-johann @songguangyu