Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. #184

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

ChrisCarini
Copy link
Owner

@ChrisCarini ChrisCarini commented Sep 29, 2023

Synced local file(s) with ChrisCarini/github-repo-files-sync.

Source Repo Commit Messages
  • Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow."

    This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd.

    Reverting because Allow fails in Remove large packages jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).

  • Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0
  • Do not delete docker images from JetBrains compatibility GitHub Workflow.

This PR was updated automatically by the ChrisCarini/repo-file-sync-action workflow run #6360711962

…rification workflow."

This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd.

Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
@ChrisCarini ChrisCarini changed the title Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. Sep 30, 2023
@pull-request-quantifier-deprecated

This PR has 7 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -3
Percentile : 2.8%

Total files changed: 1

Change summary by file extension:
.yml : +4 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ChrisCarini ChrisCarini merged commit 497e2c8 into main Sep 30, 2023
@ChrisCarini ChrisCarini deleted the repo-sync/github-repo-files-sync/default branch September 30, 2023 06:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant