Refactor Config.h and Add Noborder Patch #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the following: 1- Config.h Refactor: Improve readability of config.h, resolving past formatting issues. 2- The "noborder" patch in a superior implementation compared to those in suckless patches, as it is less prone to causing bugs. With this implementation, I have yet to encounter a single bug. I have also added a static variable in config.def.h and config.h that allows enabling or disabling noborder for those who do not wish to have this feature at all and would prefer to disable the borders completely. Additionally, you should consider changing either the unfocused client colour or the focused client colour so that they can be different, enabling us to differentiate between them, thus making the borders usable.
ChrisTitusTech
approved these changes
Apr 27, 2024
|
Looks great! Thanks for the additions @fesowowako |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the following:
1- Config.h Refactor: Improve readability of config.h, resolving past formatting issues.
2- The "noborder" patch, which permits the concealment of the border when only one client is visible, represents a superior implementation compared to those in suckless patches, as it is less prone to causing bugs. With this implementation, I have yet to encounter a single bug. I have also added a static variable in config.def.h and config.h that allows enabling or disabling noborder for those who do not wish to have this feature at all and would prefer to disable the borders completely.
You should consider changing either the unfocused client colour or the focused client colour so that they can be different, enabling us to differentiate between them, thus making the borders usable.