Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add scroll #643

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add scroll #643

wants to merge 3 commits into from

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 23, 2024 •
edited
Loading

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Add scroll when running commands.
  • Scroll using Page Up and Page Down.
  • Up and Down arrow keys are not used because it would intercept their functionality in terminal feat: Add scroll #643 (comment)

Testing

  • Works as expected.

Issues / other PRs related

Additional Information

  • The maximum scroll limit is set to 200. Can be increased in future

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@lj3954
Copy link
Contributor

lj3954 commented Sep 23, 2024

Up and down keys are used in the terminal for other behaviour, I'm not sure you'd want to intercept them.

@jeevithakannan2 jeevithakannan2 marked this pull request as draft September 23, 2024 15:04
@jeevithakannan2 jeevithakannan2 marked this pull request as ready for review September 23, 2024 15:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll or Navigate to see the output of the executed commands
2 participants
@jeevithakannan2 @lj3954