Fix AutoLogin printf and > issues

[adamperkowski]

Type of Change

• Bug fix
• Refactoring
• Hotfix

Description

A LOT of bugs here. Someone (@guruswarupa) didn't test this.

Issues / other PRs related

• Resolves AutoLogin not working #654

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have performed a self-review of my own code.
• My changes generate no errors/warnings/merge conflicts.

[nnyyxxxx]

@adamperkowski you'll have to go through and find the correct paths for each one, some of these are wrong

[adamperkowski]

@nnyyxxxx Who did this? I'd like to have a friendly talk with them...

[nnyyxxxx]

@nnyyxxxx Who did this? I'd like to have a friendly talk with them...

guru

[adamperkowski]

@guruswarupa ...

[adamperkowski]

https://wiki.archlinux.org/title/LightDM#Enabling_autologin

[cartercanedy]

I was wrong

The bsd man pages are so much better than the ones for gnutils

[nnyyxxxx]

I was wrong

The bsd man pages are so much better than the ones for gnutils

wrong

[nnyyxxxx]

thats only for bsd

[cartercanedy]

thats only for bsd

?

Which form are you talking about

[nnyyxxxx]

thats only for bsd

?

Which form are you talking about

the empty arg u mentioned in your edited message, only works for linux, bsd on the otherhand it would not work on

[cartercanedy]

thats only for bsd

?

Which form are you talking about

the empty arg u mentioned in your edited message, only works for linux, bsd on the otherhand it would not work on

sed -i'.old' 's/foo/bar/' test.txt produces a file named foo.txt.old

sed -i'' 's/foo/bar/' test.txt does not

[nnyyxxxx]

sed -i'.old' 's/foo/bar/' test.txt

that will work on bsd, but if u take the argument away it wont

[nnyyxxxx]

if there is no argument on linux it will work though, so you were only half right.

[cartercanedy]

sed -i'.old' 's/foo/bar/' test.txt

that will work on bsd, but if u take the argument away it wont

Correct, that's why I suggested the change

[cartercanedy]

I wasn't saying that I was wrong to suggest the change, just that the empty arg needed to be concatenated to the flag @nnyyxxxx

[nnyyxxxx]

I wasn't saying that I was wrong to suggest the change, just that the empty arg needed to be concatenated to the flag @nnyyxxxx

i understand i was only saying that you were partially wrong

[cartercanedy]

Ok, glad we agree...
Right?

[cartercanedy]

:)

[adamperkowski]

Co-authors for you :)

[guruswarupa]

@guruswarupa ...

It seemed to work when those lines which you changed were echo. Later while changing it to printf, it broke. I did test on my system before adding it.

[cartercanedy]

It seemed to work when those lines which you changed were echo. Later while changing it to printf, it broke. I did test on my system before adding it.

On its face that's incorrect. The single string argument being passed to sudo will fail because it will assume that it's looking for an executable named "echo '...' > ...", which fails regardless of whether you substitute echo for printf. You'd either have to run sudo bash -c "..." or do what @adamperkowski did and utilize sudo tee to get the permissions right

[nnyyxxxx]

It seemed to work when those lines which you changed were echo. Later while changing it to printf, it broke. I did test on my system before adding it.

On its face that's incorrect. The single string argument being passed to sudo will fail because it will assume that it's looking for an executable named "echo '...' > ...", which fails regardless of whether you substitute echo for printf. You'd either have to run sudo bash -c "..." or do what @adamperkowski did and utilize sudo tee to get the permissions right

i'd recommend against using sub shells