Fix the way arguments are passed to the runspace #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
ChrisTitusTech
approved these changes
Sep 11, 2024
| Start-Process -FilePath "powershell" -ArgumentList "choco feature enable -n allowGlobalConfirmation" -Wait -NoNewWindow | ||
| Set-ExecutionPolicy Bypass -Scope Process -Force; | ||
| [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; | ||
| Invoke-Expression ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1')) |
There was a problem hiding this comment.
Why did you change the method of choco install?
There was a problem hiding this comment.
The other method seemed to be broken (see discord messages)
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This is my take on fixing the Runspace problem where the arguments would be interpreted as a string instead of a list and couldn't be distinguished between the parameters of the function.
I added a new -ParameterList option to provide the parameter Name as well as the content and reverted the -ArgumentList to the old logic for backwards compatibility
Testing
I tested installs/uninstalls of programs and tweaks but not much else.