refac(invoke-wpfinstall.ps1): simplify taskbaritem invocation #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momcilovicluka
force-pushed
the
refac(invoke-wpfinstall.ps1)
branch
from
dba0087
to
e77fe1e
Compare
momcilovicluka
changed the title
momcilovicluka
force-pushed
the
refac(invoke-wpfinstall.ps1)
branch
from
e77fe1e
to
f6c2a9e
Compare
|
My apologies. Removing null asignments caused the install/uninstall to not work |
ruxunderscore
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Similar to PR #2799's change. Same opinion as there. Just as easy to read, imo, but does shorten it. I approve.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactor: functions/public/Invoke-WPFInstall.ps1
Testing
Not needed
Impact
Make code shorter and easier to read
Issue related to PR
Additional Information
Checklist