New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BCP Incorrect condition? #318

Open

adaml881 opened this issue Apr 29, 2024 · 1 comment

Labels

bug

adaml881 commented Apr 29, 2024

This if-statement is incorrect and causing field mapping errors.

if (columnMappings == null || columnMappings.Count == 0)
{
    foreach (KeyValuePair<string, string> keyValuePair in columnMappings)
        bcp.ColumnMappings.Add(keyValuePair.Key, keyValuePair.Value);
}

I think it should be

if (bcp.ColumnMappings == null || bcp.ColumnMappings.Count == 0)
{
    foreach (KeyValuePair<string, string> keyValuePair in columnMappings)
        bcp.ColumnMappings.Add(keyValuePair.Key, keyValuePair.Value);
}

https://github.com/Cinchoo/ChoETL/blame/994986e883174324d0d1f6a9147e1174f85a7fa0/src/ChoETL/Common/ChoUtility.cs#L2254

Cinchoo added the bug label

Owner

Cinchoo commented Jun 7, 2024

Yes, it is bug, will be appling fix.

Cinchoo added a commit that referenced this issue


          BCP Incorrect condition? #318

e780f12

# for free to join this conversation on GitHub. Already have an account? # to comment