-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat!: migrate to orb tools 11 | 2.0 release #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: shellcheck
chore: lint
fix: missing .sh
docs: fix word
KyleTryon
changed the title
feat: migrate to orb tools 11
feat!: migrate to orb tools 11
Sep 23, 2022
KyleTryon
changed the title
feat!: migrate to orb tools 11
feat!: migrate to orb tools 11 | 2.0 release
Sep 23, 2022
EricRibeiro
suggested changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
This was
linked to
issues
Sep 23, 2022
EricRibeiro
suggested changes
Sep 23, 2022
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
EricRibeiro
approved these changes
Sep 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the orb to Orb tools 11 and fixes a number of issues that were present in the repo, preventing the build from succeeding. Given the major version change needed, I have tested all open issues and ensured they have been addressed in this PR as well, to give us a "clean" 2.0 release. There is currently one outstanding feature request that I will implement separately.
Fixes: