[semver:minor] Allow CIRCLE_TAG to be used for deployments, fail if no tag or branch. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@campbecf Looks like the alpha version of the orb expired, mind pushing a small/empty commit so we can re-trigger the tests? |
gmemstr
suggested changes
Jul 16, 2020
gmemstr
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7
Should address this issue, as well as failing whenever a branch or tag cannot be found. This seems safer than just running on potentially an empty string.
I'm generally unfamiliar with bash scripting and conditionals, so I would appreciate if anyone else can double check my work / syntax.