Skip to content

feat: upgrade to Angular 18 #942

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bobbyg603
Copy link

@bobbyg603 bobbyg603 commented May 18, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #915

What is the new behavior?

Adds support for Angular 13 and builds library as 'partial' Ivy

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

BREAKING CHANGE: Library is now built with 'partial' Ivy

Add eslint
Add core-js
Enable Ivy
Enable Aot
Fix polyfills
Fix lint errors
Fix template compilation errors
Fix example-app build
Fix docs-app build
Fix cyclical component references (angular/angular#43227 (comment))

BREAKING CHANGE: Library is now build with 'partial' Ivy
@bobbyg603 bobbyg603 mentioned this pull request May 18, 2022
1 task
@bobbyg603
Copy link
Author

@jodaka can you please merge this change? We would like to deprecate our fork. Thanks!

@jodaka
Copy link

jodaka commented Dec 8, 2022

I wish I could! I'm just a casual user of angular-tree-component and would love to see this PR merged.
No idea why I had enough rights to review/approve your PR but I certainly don't have rights to merge it.

@bobbyg603
Copy link
Author

I wish I could! I'm just a casual user of angular-tree-component and would love to see this PR merged. No idea why I had enough rights to review/approve your PR but I certainly don't have rights to merge it.

ha! dang you could've fooled me 🙂. really disappointing to see libraries get abandoned by their maintainers.

@ikruglik
Copy link

ikruglik commented Apr 3, 2023

I wish I could! I'm just a casual user of angular-tree-component and would love to see this PR merged. No idea why I had enough rights to review/approve your PR but I certainly don't have rights to merge it.

ha! dang you could've fooled me 🙂. really disappointing to see libraries get abandoned by their maintainers.

@bobbyg603 , @jodaka have you a forked version of the lib yet with the Angular 13+ supported?

@bobbyg603
Copy link
Author

bobbyg603 commented Apr 3, 2023

@ikruglik yes, our forked version that targets Angular 13 can be found on npm

npm i @bugsplat/angular-tree-component

https://github.com/BugSplat-Git/angular-tree-component/blob/release/projects/angular-tree-component/package.json

* chore: update @angular/cli

* chore: update @angular/cdk

* chore: update @angular/material

* chore: update @angular/cli

* chore: update @angular/cdk

* chore: update @angular/material

* chore: update @angular/cli

* chore: update @angular/cdk

* chore: update @angular/material

* chore: update @angular/cli

* chore: update @angular/cdk

* chore: update @angular/cli

* chore: update @angular-eslint/schematics

* chore: install with legacy peer deps

* chore: add missing dev deps, remove unused dev deps

* chore: remove unsused code-tabs custom element

* chore: update legacy MatSnackBar

* chore: update MatButtonModule

* chore: update @angular/material

* chore: update @angular/cdk

* chore: update @angular/material

* chore: ran npm audit fix

* chore: ran npm audit fix
@bobbyg603 bobbyg603 changed the title feat: upgrade to Angular 13 feat: upgrade to Angular 18 Jul 17, 2024
@bobbyg603
Copy link
Author

hi @tobiasengelhardt, I've updated this project to use Angular 18. It's been 3 years since the last commit, perhaps you might let us take over the project?

@tobiasengelhardt
Copy link
Contributor

@bobbyg603 I wish I could, but I have no rights to merge, push or change anything in this project.

* chore: package updates

* chore: package updates

* chore: more package updates

* chore: update packages

* chore: npm audit fix

* chore: update core-js
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 12 not supported
4 participants