Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tahigash ncdiff sync and enhs #113

Merged
merged 21 commits into from
Feb 8, 2024
Merged

Tahigash ncdiff sync and enhs #113

merged 21 commits into from
Feb 8, 2024

Conversation

tahigash
Copy link
Contributor

@tahigash tahigash commented Dec 3, 2023

* yang.connector
    * updated `request` method
* yang.ncdiff
    * synced PR2, 3, 5, 8, 13, 14, 19, 21, 24, 25, 26 and 27 from ncdiff repository
    * updated NetconfCalculator class
        * added diff_type `minimum-replace`
        * added `add_attribute_at_depath` method
        * added `add_attribute_by_xpath` method
        * added `find_by_tags` method
    * updated ConfigDelta class
        * added `replace_xpath` argument
        * added `find_by_tags` method

NOTE: codes syncing from ncdiff are reviewed and merged on ncdiff repo. so no need to review those much.
https://github.com/CiscoTestAutomation/ncdiff/pulls?q=is%3Apr+is%3Aclosed

connector UT:

Ran 16 tests in 0.898s

FAILED (errors=1)

NOTE: same error even with master branch. so not because of my PR

ncdiff UT:

Ran 54 tests in 0.291s

OK

@tahigash tahigash marked this pull request as ready for review February 6, 2024 04:20
@tahigash tahigash requested a review from a team as a code owner February 6, 2024 04:20
@tahigash tahigash requested review from Taarini and omehrabi February 6, 2024 04:20
@tahigash tahigash changed the title Tahigash ncdiff sync Tahigash ncdiff sync and enhs Feb 6, 2024
@omehrabi omehrabi requested a review from dwapstra February 7, 2024 18:15
Copy link
Contributor

@dwapstra dwapstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, please update docs as commented.

Co-authored-by: Dave Wapstra <dwapstra@cisco.com>
@tahigash tahigash requested a review from dwapstra February 8, 2024 22:19
@tahigash tahigash merged commit 33d3122 into master Feb 8, 2024
@tahigash tahigash deleted the tahigash_ncdiff_sync branch February 8, 2024 22:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants