Add ssh proxy for grpc #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omehrabi
commented
Jan 29, 2024
omehrabi
commented
Jan 29, 2024
omehrabi
commented
Jan 29, 2024
omehrabi
commented
Jan 29, 2024
| remote_tunnel_port = sshtunnel.add_tunnel(proxy_conn=proxy_dev.connectionmgr.connections.cli, tunnel_type='remote', target_port=allocated_port) | ||
| # create a proxy port on the proxy using socat api for redirecting traffic to the port for remote tunnel | ||
| proxy_port = proxy_dev.api.socat_relay('127.0.0.1', remote_tunnel_port) | ||
| mgmt_ip = self.access_ip or self.device.management.get('address').get('ipv4') |
There was a problem hiding this comment.
Suggested change
| mgmt_ip = self.access_ip or self.device.management.get('address').get('ipv4') | |
| mgmt_ip = self.access_ip or self.device.management.get('address',{}).get('ipv4') |
omehrabi
commented
Jan 29, 2024
omehrabi
commented
Jan 29, 2024
dwapstra
reviewed
Jan 30, 2024
dwapstra
reviewed
Jan 30, 2024
dwapstra
reviewed
Jan 30, 2024
dwapstra
reviewed
Jan 30, 2024
dwapstra
reviewed
Jan 30, 2024
| dev = testbed.devices['router-1'] | ||
| dev.connections['grpc'].update({'sshtunnel':{'host':'proxy'}}) | ||
| testbed.devices['proxy'] = proxy | ||
| with mock.patch('yang.connector.grpc.telegraf.sshtunnel.add_tunnel') as sshtuneel_mock: |
There was a problem hiding this comment.
Suggested change
| with mock.patch('yang.connector.grpc.telegraf.sshtunnel.add_tunnel') as sshtuneel_mock: | |
| with mock.patch('yang.connector.grpc.telegraf.sshtunnel.add_tunnel') as sshtunnel_mock: |
dwapstra
reviewed
Jan 30, 2024
dwapstra
reviewed
Jan 30, 2024
dwapstra
reviewed
Feb 1, 2024
dwapstra
reviewed
Feb 1, 2024
| # add a remote tunnel on the proxy for the allocated port on the execution host | ||
| remote_tunnel_port = sshtunnel.add_tunnel(proxy_conn=proxy_dev.connectionmgr.connections.cli, tunnel_type='remote', target_port=allocated_port) | ||
| # create a proxy port on the proxy using socat api for redirecting traffic to the port for remote tunnel | ||
| proxy_port = proxy_dev.api.socat_relay('127.0.0.1', remote_tunnel_port) |
There was a problem hiding this comment.
should use start_socat_relay (once the API is available in genielibs) and stop_socat_relay in disconnect()
dwapstra
requested changes
Feb 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will let the transporter connect to the device using a proxy