Fix broken EFilePocket on Integrated AR Bionic #79361
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
BasicBuildPassed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix broken EFilePocket on Integrated AR Bionic"
Purpose of change
The Integrated AR Bionic no longer works for reading and scanning books now that the EFile Storage system is here. Looks like it was missed.
Describe the solution
Fix #79358 by adding the correct pocket to the fake item.
I set the size to 2tb and based the data transfer speed on this micro-sd card. (It says 240MB/s but apparently it's top write speed is actually 140MB/s.)
I gave it a phone connection type. I imagine you just lift up your eyelid and there's a micro USB port there. Or maybe it does Bluetooth 😂.
Describe alternatives you've considered
I could try to "sci-fi" up the values since bionics are meant to be beyond what we have access to right now. But I am also hard pressed to imagine a scenario where you need more storage. (At least under the current storage model.)
Testing
Loaded up a game. Gave myself the bionic. Tried scanning a book. Bug is fixed.
Additional context