Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove "Slowdown Fungal Growth" mod #79801

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

The mod "Slowdown Fungal Growth" does not meet the criteria for our in-repo mods. It is a simple balance mod which changes one(1) creature in the game.

Its existence impairs development and whenever newer players ask about fungals growing raises questions about "Did you disable the default mod?" etc.

It clogs up the mod list. We have lots of really impactful, beautiful mods which offer entirely different gameplay and settings. This isn't one of them.

There's simply no reason for the mod to exist.

Describe the solution

Nix it. Obsolete the mod itself and mainline its effects. Add notes to the only content it changed explaining why things are the way they are, to carry us into a future with hopefully rebalanced fungals.

Describe alternatives you've considered

Well we could just delete the mod without mainlining it...

Testing

CI might need to be adjusted to account for it being obsolete. We'll see.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 22, 2025
@PatrikLundell
Copy link
Contributor

I agree with the change, but what happens to existing games when the mod is removed?

Does marking the mod as obsolete cause it to be kept, dropped silently, in a way informing the player that the mod is obsolete, or will the game simply complain without an explanation?
If it's the third case it matters what the message looks like, as an unsuitable message may cause players to wonder what it happening and whether their game is broken.

@GuardianDll
Copy link
Member

obsoleted mods are hidden from the mod menu, but preserved in the existing save file

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 22, 2025
@Karol1223
Copy link
Contributor

Karol1223 commented Feb 22, 2025

I believe there now currently is support for straight up removing mods. Procyonae did it for some very old map mods if I recall.

@kevingranade kevingranade merged commit 337582d into CleverRaven:master Feb 22, 2025
30 checks passed
@RenechCDDA RenechCDDA deleted the prune_unwanted_mod branch February 22, 2025 11:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants