Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typo in the README directory for ECCO errors #343

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Typo in the README directory for ECCO errors #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d518658
Changed the ECCO Password/Username error to have the correct director…
taimoorsohail Feb 20, 2025
d77a6d1
Made a mistake in the file path -- fixed now
taimoorsohail Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an attempt to reduce the wonder why gitignore appeared to have changed. Seems like you deleted an empty line in the end. Sometimes our editor might be doing this automatically (similar for trailing spaces) because of a setting/an extension.

Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ docs/src/literated/
*.nsys-rep
*.ncu-rep
*.sq
*.sqlite
*.sqlite
6 changes: 3 additions & 3 deletions src/DataWrangling/ECCO/ECCO_metadata.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,15 +250,15 @@ function download_dataset(metadata::ECCOMetadata; url = urls(metadata))
filepath = metadata_path(metadatum)

if !isfile(filepath)
instructions_msg = "\n See ClimaOcean.jl/src/ECCO/README.md for instructions."
instructions_msg = "\n See ClimaOcean.jl/src/DataWrangling/ECCO/README.md for instructions."
if isnothing(username)
msg = "Could not find the ECCO_PASSWORD environment variable. \
See ClimaOcean.jl/src/ECCO/README.md for instructions on obtaining \
See ClimaOcean.jl/src/DataWrangling/ECCO/README.md for instructions on obtaining \
and setting your ECCO_USERNAME and ECCO_PASSWORD." * instructions_msg
throw(ArgumentError(msg))
elseif isnothing(password)
msg = "Could not find the ECCO_PASSWORD environment variable. \
See ClimaOcean.jl/src/ECCO/README.md for instructions on obtaining \
See ClimaOcean.jl/src/DataWrangling/ECCO/README.md for instructions on obtaining \
and setting your ECCO_USERNAME and ECCO_PASSWORD." * instructions_msg
throw(ArgumentError(msg))
end
Expand Down
Loading